linting the Bot

1 files changed, 64 insertions, 67 deletions

diff --git a/buildbot/master.cfg b/buildbot/master.cfg
index 212ae5c..3f311b4 100644
--- a/buildbot/master.cfg
+++ b/buildbot/master.cfg
@@ -46,9 +46,9 @@ c["protocols"] = {
 # about source code changes.
 
 # NOTE: BB is bound to localhost
-allcs = changes.PBChangeSource(user="allcs", passwd="allcs")
+ALLCS = changes.PBChangeSource(user="allcs", passwd="allcs")
 
-c["change_source"] = [allcs]
+c["change_source"] = [ALLCS]
 
 ####### SCHEDULERS
 
@@ -56,7 +56,7 @@ c["change_source"] = [allcs]
 
 # Re-build documentation periodically
 
-doc_scheduler = schedulers.SingleBranchScheduler(
+DOC_SCHEDULER = schedulers.SingleBranchScheduler(
     name="periodic-doc-scheduler",
     builderNames=["doc-builder"],
     change_filter=util.ChangeFilter(
@@ -64,7 +64,7 @@ doc_scheduler = schedulers.SingleBranchScheduler(
         project_re="api|www"),
     treeStableTimer=None)
 
-wallet_scheduler = schedulers.SingleBranchScheduler(
+WALLET_SCHEDULER = schedulers.SingleBranchScheduler(
     name="wallet-scheduler",
     change_filter=util.ChangeFilter(
         branch="master",
@@ -72,7 +72,7 @@ wallet_scheduler = schedulers.SingleBranchScheduler(
     treeStableTimer=None,
     builderNames=["wallet-builder"])
 
-all_scheduler = schedulers.SingleBranchScheduler(
+ALL_SCHEDULER = schedulers.SingleBranchScheduler(
     name="all-scheduler",
     change_filter=util.ChangeFilter(
         branch="master",
@@ -86,7 +86,7 @@ all_scheduler = schedulers.SingleBranchScheduler(
 
 # Scheduler monitoring the help.git repo; a forgotten repo we
 # use to test BB.
-debug_scheduler = schedulers.SingleBranchScheduler(
+DEBUG_SCHEDULER = schedulers.SingleBranchScheduler(
     name="debug-scheduler",
     change_filter=util.ChangeFilter(
         branch="master",
@@ -95,7 +95,7 @@ debug_scheduler = schedulers.SingleBranchScheduler(
     builderNames=["debug-builder"])
 
 # Consider adding other Python parts, like the various frontends.
-lint_scheduler = schedulers.SingleBranchScheduler(
+LINT_SCHEDULER = schedulers.SingleBranchScheduler(
     name="lint-scheduler",
     change_filter=util.ChangeFilter(
         branch="master",
@@ -104,7 +104,7 @@ lint_scheduler = schedulers.SingleBranchScheduler(
     builderNames=["lint-builder"])
 
 # Provide "force" button in the web UI
-force_scheduler = schedulers.ForceScheduler(
+FORCE_SCHEDULER = schedulers.ForceScheduler(
     name="force-scheduler",
     builderNames=[
         "lcov-builder",
@@ -114,12 +114,12 @@ force_scheduler = schedulers.ForceScheduler(
         "wallet-builder"])
 
 c["schedulers"] = [
-    doc_scheduler,
-    wallet_scheduler,
-    all_scheduler,
-    force_scheduler,
-    debug_scheduler,
-    lint_scheduler]
+    DOC_SCHEDULER,
+    WALLET_SCHEDULER,
+    ALL_SCHEDULER,
+    FORCE_SCHEDULER,
+    DEBUG_SCHEDULER,
+    LINT_SCHEDULER]
 
 ####### BUILDERS
 
@@ -127,11 +127,8 @@ c["schedulers"] = [
 # what steps, and which workers can execute them.  Note that any particular build will
 # only take place on one worker.
 
-# FIXME: the bad side of these builders is that they expect the worker's environment
-# to be _already_ set up (codedbases, scripts, etc).  In other words, it's not "self-contained".
-
-wallet_factory = util.BuildFactory()
-wallet_factory.addStep(Git(
+WALLET_FACTORY = util.BuildFactory()
+WALLET_FACTORY.addStep(Git(
     repourl="git://git.taler.net/wallet-webex.git",
     mode="full",
     method="fresh",
@@ -139,28 +136,28 @@ wallet_factory.addStep(Git(
     alwaysUseLatest=True,
     haltOnFailure=True,
     branch="master"))
-wallet_factory.addStep(ShellCommand(
+WALLET_FACTORY.addStep(ShellCommand(
     name="configuration",
     description="Running configure script",
     descriptionDone="Correctly configured",
     command=["./configure"],
     workdir="build/"))
-wallet_factory.addStep(ShellCommand(
+WALLET_FACTORY.addStep(ShellCommand(
     name="test",
     description="Running wallet tests",
     descriptionDone="Test correctly run",
     command=["make", "check"],
     workdir="build/"))
 
-debug_factory = util.BuildFactory()
-debug_factory.addStep(ShellCommand(
+DEBUG_FACTORY = util.BuildFactory()
+DEBUG_FACTORY.addStep(ShellCommand(
     name="echo debug",
     description="just echoing a word",
     descriptionDone="builder responded",
     command=["echo", "I'm here!"]))
 
-lint_factory = util.BuildFactory()
-lint_factory.addStep(Git(
+LINT_FACTORY = util.BuildFactory()
+LINT_FACTORY.addStep(Git(
     repourl='git://git.taler.net/bank.git',
     mode="full",
     method="fresh",
@@ -168,7 +165,7 @@ lint_factory.addStep(Git(
     alwaysUseLatest=True,
     haltOnFailure=True,
     branch="master"))
-lint_factory.addStep(ShellCommand(
+LINT_FACTORY.addStep(ShellCommand(
     name="code linter",
     description="running static analysis",
     descriptionDone="static analysis done",
@@ -177,8 +174,8 @@ lint_factory.addStep(ShellCommand(
              "pylint_django",
              "talerbank/"]))
 
-lcov_factory = util.BuildFactory()
-lcov_factory.addStep(Git(
+LCOV_FACTORY = util.BuildFactory()
+LCOV_FACTORY.addStep(Git(
     repourl='git://git.taler.net/deployment.git',
     mode="full",
     method='fresh',
@@ -186,13 +183,13 @@ lcov_factory.addStep(Git(
     alwaysUseLatest=True,
     haltOnFailure=True,
     branch='master'))
-lcov_factory.addStep(ShellCommand(
+LCOV_FACTORY.addStep(ShellCommand(
     name="invalidation",
     description="Invalidating timestamps",
     descriptionDone="timestamps invalidated",
     command=["./invalidate.sh"],
     workdir="build/taler-build"))
-lcov_factory.addStep(ShellCommand(
+LCOV_FACTORY.addStep(ShellCommand(
     name="build",
     description="Compiling..",
     descriptionDone="lcov files generated",
@@ -201,8 +198,8 @@ lcov_factory.addStep(ShellCommand(
     env={"PATH": "${HOME}/local/bin:${PATH}",
          "TALER_CHECKDB": "postgresql:///talercheck?host=/home/${USER}/sockets"}))
 
-switcher_factory = util.BuildFactory()
-switcher_factory.addStep(Git(
+SWITCHER_FACTORY = util.BuildFactory()
+SWITCHER_FACTORY.addStep(Git(
     repourl='git://git.taler.net/deployment.git',
     mode="full",
     method="fresh",
@@ -210,33 +207,33 @@ switcher_factory.addStep(Git(
     alwaysUseLatest=True,
     haltOnFailure=True,
     branch="master"))
-switcher_factory.addStep(ShellCommand(
+SWITCHER_FACTORY.addStep(ShellCommand(
     name="build",
     description="Building inactive blue-green party.",
     descriptionDone="Compile.",
     command=["./build.sh"],
     workdir="build/buildbot"))
-switcher_factory.addStep(ShellCommand(
+SWITCHER_FACTORY.addStep(ShellCommand(
     name="restart services",
     description="Restarting inactive blue-green party.",
     descriptionDone="Restarting Taler.",
     command=["./restart.sh"],
     workdir="build/buildbot"))
-switcher_factory.addStep(ShellCommand(
+SWITCHER_FACTORY.addStep(ShellCommand(
     name="check services correctly restarted",
     description="Checking services are correctly restarted.",
     descriptionDone="All services are correctly restarted.",
     command=["./checks.sh"],
     workdir="build/buildbot"))
-switcher_factory.addStep(ShellCommand(
+SWITCHER_FACTORY.addStep(ShellCommand(
     name="switch active party",
     description="Switch to the party which was inactive.",
     descriptionDone="Active party has been switched.",
     command=["./switch.sh"],
     workdir="build/buildbot"))
 
-selenium_factory = util.BuildFactory()
-selenium_factory.addStep(ShellCommand(
+SELENIUM_FACTORY = util.BuildFactory()
+SELENIUM_FACTORY.addStep(ShellCommand(
     name="selenium",
     description="Headless browser test",
     descriptionDone="Test finished",
@@ -244,8 +241,8 @@ selenium_factory.addStep(ShellCommand(
     env={'PATH': "${HOME}/local/bin:/usr/lib/chromium:${PATH}"}))
 
 # this factory builds {api,docs}.taler.net AND {www,stage}.taler.net
-doc_factory = util.BuildFactory()
-doc_factory.addStep(Git(
+DOC_FACTORY = util.BuildFactory()
+DOC_FACTORY.addStep(Git(
     repourl="git://git.taler.net/deployment.git",
     mode="full",
     method="fresh",
@@ -253,68 +250,68 @@ doc_factory.addStep(Git(
     alwaysUseLatest=True,
     haltOnFailure=True,
     branch='master'))
-doc_factory.addStep(ShellCommand(
+DOC_FACTORY.addStep(ShellCommand(
     name="build docs",
     description="Building documentation.",
     descriptionDone="Documentation built.",
     command=["./update_docs.sh"],
     workdir="build/taler-build"))
-doc_factory.addStep(ShellCommand(
+DOC_FACTORY.addStep(ShellCommand(
     name="build www",
     description="Building www.taler.net.",
     descriptionDone="www.taler.net built",
     command=["./update_www.sh"],
     workdir="build/taler-build"))
-doc_factory.addStep(ShellCommand(
+DOC_FACTORY.addStep(ShellCommand(
     name="build www-stage",
     description="Building stage.taler.net.",
     descriptionDone="stage.taler.net built",
     command=["./update_stage.sh"],
     workdir="build/taler-build"))
 
-debug_builder = util.BuilderConfig(
+DEBUG_BUILDER = util.BuilderConfig(
     name="debug-builder",
     workernames=["debug-worker"],
-    factory=debug_factory)
+    factory=DEBUG_FACTORY)
 
-lint_builder = util.BuilderConfig(
+LINT_BUILDER = util.BuilderConfig(
     name="lint-builder",
     workernames=["lint-worker"],
-    factory=lint_factory)
+    factory=LINT_FACTORY)
 
-lcov_builder = util.BuilderConfig(
+LCOV_BUILDER = util.BuilderConfig(
     name="lcov-builder",
     workernames=["lcov-worker"],
-    factory=lcov_factory)
+    factory=LCOV_FACTORY)
 
-switcher_builder = util.BuilderConfig(
+SWITCHER_BUILDER = util.BuilderConfig(
     name="switcher-builder",
     workernames=["switcher-worker"],
-    factory=switcher_factory)
+    factory=SWITCHER_FACTORY)
 
-selenium_builder = util.BuilderConfig(
+SELENIUM_BUILDER = util.BuilderConfig(
     name="selenium-builder",
     workernames=["selenium-worker"],
-    factory=selenium_factory)
+    factory=SELENIUM_FACTORY)
 
-doc_builder = util.BuilderConfig(
+DOC_BUILDER = util.BuilderConfig(
     name="doc-builder",
     workernames=["doc-worker"],
-    factory=doc_factory)
+    factory=DOC_FACTORY)
 
-wallet_builder = util.BuilderConfig(
+WALLET_BUILDER = util.BuilderConfig(
     name="wallet-builder",
     workernames=["wallet-worker"],
-    factory=wallet_factory)
+    factory=WALLET_FACTORY)
 
 c["builders"] = [
-    lcov_builder,
-    switcher_builder,
-    selenium_builder,
-    doc_builder,
-    wallet_builder,
-    debug_builder,
-    lint_builder]
+    LCOV_BUILDER,
+    SWITCHER_BUILDER,
+    SELENIUM_BUILDER,
+    DOC_BUILDER,
+    WALLET_BUILDER,
+    DEBUG_BUILDER,
+    LINT_BUILDER]
 
 ####### BUILDBOT SERVICES
 
@@ -322,7 +319,7 @@ c["builders"] = [
 # status of each build will be pushed to these targets. buildbot/reporters/*.py
 # has a variety to choose from, like IRC bots.
 
-irc = reporters.IRC(
+IRC = reporters.IRC(
     "irc.eu.freenode.net",
     "taler-bb",
     useColors=False,
@@ -333,7 +330,7 @@ irc = reporters.IRC(
         'successToFailure': 1,
         'failureToSuccess': 1})
 
-email = reporters.MailNotifier(
+EMAIL = reporters.MailNotifier(
     fromaddr="testbuild@taler.net",
     sendToInterestedUsers=False,
     mode=("problem"),
@@ -345,7 +342,7 @@ email = reporters.MailNotifier(
     extraRecipients=["buildfailures@taler.net"],
     subject="Taler build.")
 
-c["services"] = [irc, email]
+c["services"] = [IRC, EMAIL]
 
 ####### PROJECT IDENTITY