summaryrefslogtreecommitdiff
path: root/vcbuild.bat
AgeCommit message (Collapse)Author
2018-01-11build,win: restore vcbuild TAG functionalityRod Vagg
--tag needs to be set after `getnodeversion` because TAG is defined in there when DISTTYPE is not "release", setting it before `getnodeversion` leads to --tag not being passed down in to `configure` and src/node_version.h setting it as `-pre` by default. This change restores the functionality that properly sets the TAG for nightlies, rc builds and other custom build types. Ref: https://github.com/nodejs/node/pull/17299 Ref: https://github.com/nodejs/abi-stable-node/issues/289 PR-URL: https://github.com/nodejs/node/pull/18031 Ref: https://github.com/nodejs/node/pull/17299 Ref: https://github.com/nodejs/abi-stable-node/issues/289 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: JoãReis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
2018-01-11tools: move eslint from tools to tools/node_modulesMichaël Zasso
This is required because we need to add the babel-eslint dependency and it has to be able to resolve "eslint". babel-eslint is required to support future ES features such as async iterators and import.meta. Refs: https://github.com/nodejs/node/pull/17755 PR-URL: https://github.com/nodejs/node/pull/17820 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2018-01-02build: remove duplicate async-hooks and known_issues test runsRich Trott
The `default` test suite in `test.py` includes `async-hooks` and `known_issues`. Our current setup results in those test suites being run twice during each CI run. Remove the duplication. PR-URL: https://github.com/nodejs/node/pull/17912 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2017-12-15win, build: fix without-intl optionBartosz Sosnowski
Fixes --with-intl option passed to configure script when without-intl is used PR-URL: https://github.com/nodejs/node/pull/17614 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2017-12-12build: remove support for VS2015Nikolai Vavilov
PR-URL: https://github.com/nodejs/node/pull/16969 Refs: https://github.com/nodejs/node/pull/16868 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2017-12-07build, win: faster Release rebuildsBartosz Sosnowski
Sets Link Time Code Generation to INCREMENTAL improving Release rebuilds speed. Adds no-cctest option to vcbuild.bat, which will skip building cctest.exe PR-URL: https://github.com/nodejs/node/pull/17393 Reviewed-By: Refael Ackermann <refack@gmail.com>
2017-12-02build,win: vcbuild refactoring call configureRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/17299 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2017-11-28build,win,msi: support WiX with VS2017João Reis
PR-URL: https://github.com/nodejs/node/pull/17101 Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
2017-11-16Revert "build: for --enable-static, run only cctest"Daniel Bevenius
This reverts commit a36b5405029597ce09e15373a321c47930689c08. PR-URL: https://github.com/nodejs/node/pull/14986 Refs: https://github.com/nodejs/node/issues/14158 Refs: https://github.com/nodejs/node/pull/14892 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2017-11-09build: include src\tracing when linting on winDaniel Bevenius
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. PR-URL: https://github.com/nodejs/node/pull/16720 Reviewed-By: James M Snell <jasnell@gmail.com>
2017-11-08build: add missing options to help messageDaniel Bevenius
This commit add missing options to the Windows help message and removes options that no longer exist (test-uv). PR-URL: https://github.com/nodejs/node/pull/16707 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2017-10-26build: improve `make clean`Refael Ackermann
also undocument the `vcbuild.bat` command since it's broken and seems to only be relevant to release builds PR-URL: https://github.com/nodejs/node/pull/16372 Refs: https://github.com/nodejs/node/pull/16010 Refs: https://github.com/nodejs/node/issues/16278 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2017-10-19build: revert "call setlocal in vcbuild.bat"Refael Ackermann
This reverts commit b9a55a93c91fb7fd7ac81e182f843f28014179ca. PR-URL: https://github.com/nodejs/node/pull/16270 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2017-10-19test: update test-npm to use test-npm-package.jsGibson Fahnestock
Deletes the old test-npm.sh script. PR-URL: https://github.com/nodejs/node/pull/11540 Refs: https://github.com/nodejs/node/pull/7867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
2017-10-17test: move inspector tests to parallel/sequentialJon Moss
* remove inspector directory artifacts PR-URL: https://github.com/nodejs/node/pull/16197 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2017-10-17build,win: enable lint option to run "standalone"Daniel Bevenius
This commit adds support to run the linter without running any other targets. This commit also makes the lint task a little more quite and more inline with the output on other operating systems. Below is an example of running (with a lint error to show that it is not so quite that errors are hidden): C:\Users\danbev\working\node>vcbuild.bat lint running lint-cpp 'src\*.c src\*.cc src\*.h test\addons\*.cc test\addons\*.h test\cctest\*.cc test\cctest\*.h test\gc\binding.cc tools\icu\*.cc tools\icu\*.h' src\env.h:24: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 1 "C:\Python27\python.exe" tools/check-imports.py running lint-js The help message now looks like: C:\Users\danbev\working\node>vcbuild.bat /? vcbuild.bat [debug/release] [msi] [test/test-ci/test-all/test-uv/ test-inspector/test-internet/test-pummel/test-simple/test-message/ test-async-hooks/test-v8/test-v8-intl/test-v8-benchmarks/ test-v8-all] [clean] [noprojgen] [small-icu/full-icu/without-intl] [nobuild] [sign] [x86/x64] [vs2015/vs2017] [download-all] [enable-vtune] [lint/lint-ci] [no-NODE-OPTIONS] [link-module path-to-module] Examples: vcbuild.bat : builds release build vcbuild.bat debug : builds debug build vcbuild.bat release msi : builds release build and MSI installer package vcbuild.bat test : builds debug build and runs tests vcbuild.bat build-release : builds the release distribution as used by nodejs.org vcbuild.bat enable-vtune : builds nodejs with Intel VTune profiling support to profile JavaScript vcbuild.bat link-module my_module.js : bundles my_module as built-in module vcbuild.bat lint : runs the C++ and JavaScript linter PR-URL: https://github.com/nodejs/node/pull/16176 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2017-10-16build,win: include addons-napi in linterDaniel Bevenius
Currently test/addons-napi files are not being included in the lint processing. This commit adds them. PR-URL: https://github.com/nodejs/node/pull/16181 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2017-10-05build: call setlocal in vcbuild.batDaniel Bevenius
Currently the variables set in vcbuild.bat are mostly global and escape/leak out into the calling process. For example, running vcbuild.bat test and then echoing the config variable gives: vcbuild.bat test ... echo %config% Release After this change the same command give: vcbuild.bat test ... echo %config% %config% PR-URL: https://github.com/nodejs/node/pull/15754 Reviewed-By: James M Snell <jasnell@gmail.com>
2017-10-01test: make it easier to run tests for subsystemsBenjamin Coe
You can now run suites for subsystem using shorthand, e.g., http. Switch to black-list of default test folders from white-list. Tests run by 'make test', 'make coverage', etc., now configurable. Stop running known_issues suite when collecting test coverage. PR-URL: https://github.com/nodejs/node/pull/15450 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
2017-09-27build: run es-module tests in CIBenjamin Coe
Add es-module to CI_JS_SUITES/js_test_suites, so that tests run in CI. Update test/README adding es-module section. PR-URL: https://github.com/nodejs/node/pull/15276 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
2017-09-24build: use generic names for linting tasksNikolai Vavilov
"jslint" is the name of a tool that actually is not used, which can cause confusion. PR-URL: https://github.com/nodejs/node/pull/15272 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
2017-09-21build: don't fail `make test` on source tarballsGibson Fahnestock
Tries to achieve the same effect as https://github.com/nodejs/node/pull/13658 without breaking source tarballs. Presumably if `tools/eslint` wasn't there at all, people would notice in the PR review! PR-URL: https://github.com/nodejs/node/pull/15441 Fixes: https://github.com/nodejs/node/issues/14513 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2017-09-19build: add support for link-module to vcbuildBartosz Sosnowski
Adds support for link-module option to vcbuild.bat. PR-URL: https://github.com/nodejs/node/pull/15410 Fixes: https://github.com/nodejs/node/issues/15377 Reviewed-By: Refael Ackermann <refack@gmail.com>
2017-09-03test,process: run 'abort' suite on WindowsRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/15056 Fixes: https://github.com/nodejs/node/issues/14012 Refs: https://github.com/nodejs/node/pull/14013 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2017-08-29build: add npx to zip and 7z packagesRichard Lau
Copy npx and npx.cmd from `deps\npm\bin` for consistency with .msi package. PR-URL: https://github.com/nodejs/node/pull/15033 Refs: https://github.com/nodejs/node/pull/14235 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2017-08-24build: for --enable-static, run only cctestDaniel Bevenius
Currently when building with --enable-static and running the test target the following error will be reported: Building addon /node/test/addons/01_function_arguments/ env: ./node: No such file or directory make[1]: *** [test/addons/.buildstamp] Error 1 Note that this is with a clean build where no prior node executable was built. This commit suggests only running the cctest target when --enable-static is specified. PR-URL: https://github.com/nodejs/node/pull/14892 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com>
2017-08-17src: use `unordered_set` instead of custom rb treeAnna Henningsen
Use a standard hash-based container instead of the custom included red/black tree implementation. There is likely no noticeable performance difference, and if there is one, it is very likely to be an improvement. PR-URL: https://github.com/nodejs/node/pull/14826 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2017-08-04http2: introducing HTTP/2James M Snell
At long last: The initial *experimental* implementation of HTTP/2. This is an accumulation of the work that has been done in the nodejs/http2 repository, squashed down to a couple of commits. The original commit history has been preserved in the nodejs/http2 repository. This PR introduces the nghttp2 C library as a new dependency. This library provides the majority of the HTTP/2 protocol implementation, with the rest of the code here providing the mapping of the library into a usable JS API. Within src, a handful of new node_http2_*.c and node_http2_*.h files are introduced. These provide the internal mechanisms that interface with nghttp and define the `process.binding('http2')` interface. The JS API is defined within `internal/http2/*.js`. There are two APIs provided: Core and Compat. The Core API is HTTP/2 specific and is designed to be as minimal and as efficient as possible. The Compat API is intended to be as close to the existing HTTP/1 API as possible, with some exceptions. Tests, documentation and initial benchmarks are included. The `http2` module is gated by a new `--expose-http2` command line flag. When used, `require('http2')` will be exposed to users. Note that there is an existing `http2` module on npm that would be impacted by the introduction of this module, which is the main reason for gating this behind a flag. When using `require('http2')` the first time, a process warning will be emitted indicating that an experimental feature is being used. To run the benchmarks, the `h2load` tool (part of the nghttp project) is required: `./node benchmarks/http2/simple.js benchmarker=h2load`. Only two benchmarks are currently available. Additional configuration options to enable verbose debugging are provided: ``` $ ./configure --debug-http2 --debug-nghttp2 $ NODE_DEBUG=http2 ./node ``` The `--debug-http2` configuration option enables verbose debug statements from the `src/node_http2_*` files. The `--debug-nghttp2` enables the nghttp library's own verbose debug output. The `NODE_DEBUG=http2` enables JS-level debug output. The following illustrates as simple HTTP/2 server and client interaction: (The HTTP/2 client and server support both plain text and TLS connections) ```jt client = http2.connect('http://localhost:80'); const req = client.request({ ':path': '/some/path' }); req.on('data', (chunk) => { /* do something with the data */ }); req.on('end', () => { client.destroy(); }); // Plain text (non-TLS server) const server = http2.createServer(); server.on('stream', (stream, requestHeaders) => { stream.respond({ ':status': 200 }); stream.write('hello '); stream.end('world'); }); server.listen(80); ``` ```js const http2 = require('http2'); const client = http2.connect('http://localhost'); ``` Author: Anna Henningsen <anna@addaleax.net> Author: Colin Ihrig <cjihrig@gmail.com> Author: Daniel Bevenius <daniel.bevenius@gmail.com> Author: James M Snell <jasnell@gmail.com> Author: Jun Mukai Author: Kelvin Jin Author: Matteo Collina <matteo.collina@gmail.com> Author: Robert Kowalski <rok@kowalski.gd> Author: Santiago Gimeno <santiago.gimeno@gmail.com> Author: Sebastiaan Deckers <sebdeckers83@gmail.com> Author: Yosuke Furukawa <yosuke.furukawa@gmail.com> PR-URL: https://github.com/nodejs/node/pull/14239 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2017-08-01build,win: fix python detection scriptJason Ginchereau
Handle spaces in the path to python.exe, in case it is installed under some directory like "C:\Program Files". PR-URL: https://github.com/nodejs/node/pull/14546 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
2017-07-26build,test: run v8 tests on windowsKunal Pathak
`vcbuild.bat test-v8` : Runs unit test from v8 repo `vcbuild.bat test-v8-intl` : Runs intl test from v8 repo `vcbuild.bat test-v8` : Runs benchmarks from v8 repo The runs needs https://www.chromium.org/developers/how-tos/install-depot-tools installed on the machine expects environment variable `DEPOT_TOOLS_PATH` to be set to the path. Set environment variable `DISABLE_V8_I18N` to disable i18n. PR-URL: https://github.com/nodejs/node/pull/13992 Refs: https://github.com/nodejs/node/pull/4704 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
2017-07-17build: prevent VsDevCmd.bat from changing cwdNikolai Vavilov
VsDevCmd.bat changes the current working directory to "%USERPROFILE%\Source" if it exists. Setting VSCMD_START_DIR overrides this behavior. PR-URL: https://github.com/nodejs/node/pull/14303 Fixes: https://github.com/nodejs/node/issues/14300 Refs: https://developercommunity.visualstudio.com/content/problem/26780/vsdevcmdbat-changes-the-current-working-directory.html Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2017-07-09build: split up cpplint to avoid long cmd linesKyle Farnung
Refactors cpplint slightly to allow multiple runs of it. This allows downstream projects to run cpplint on their dependencies. PR-URL: https://github.com/nodejs/node/pull/14116 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: João Reis <reis@janeasystems.com>
2017-07-09build,win: skip `vcvarsall.bat` if env is setRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/13806 Fixes: https://github.com/nodejs/node/issues/13765 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Kunal Pathak <kunal.pathak@microsoft.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
2017-07-01build: add async-hooks testing to vcbuild.batRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/13381 Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
2017-06-30build,windows: restore DISTTYPEDIRRefael Ackermann
* rename :exit to :distexit PR-URL: https://github.com/nodejs/node/pull/13969 Refs: https://github.com/nodejs/node/pull/13900#pullrequestreview-46906389 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
2017-06-30build,win: respect VS version for building addonsJoão Reis
When building in machines with multiple versions of Visual Studio installed, node-gyp should respect the vs2015/vs2017 arguments passed to vcbuild.bat instead of relying on its own detection mechanism. PR-URL: https://github.com/nodejs/node/pull/13911 Reviewed-By: Refael Ackermann <refack@gmail.com>
2017-06-30build,win: use latest installed VS by defaultJoão Reis
vcbuild.bat should detect what version of Visual Studio to use, it should simply work without any parameter if any supported version is installed. It should default to the latest version, to match the behavior of `node-gyp`. PR-URL: https://github.com/nodejs/node/pull/13911 Fixes: https://github.com/nodejs/node/issues/13641 Reviewed-By: Refael Ackermann <refack@gmail.com>
2017-06-28build,windows: implement PEP514 python detectionRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/13900 Fixes: https://github.com/nodejs/node/issues/13882 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2017-06-17build: check for linter in bin rather than libRich Trott
Make the "can we lint?" check in Makefile and vcbuild.bat depend on bin/eslint.js rather than lib/eslint.js. In ESLint 4.0.0, lib/eslint.js is not present. The lint rules call bin/eslint.js so check for that instead. PR-URL: https://github.com/nodejs/node/pull/13645 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2017-06-17src,lib,test,doc: correct misspellingsRoman Reiss
PR-URL: https://github.com/nodejs/node/pull/13719 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
2017-06-16build: fail linter if linting not availableGibson Fahnestock
PR-URL: https://github.com/nodejs/node/pull/13658 Ref: https://github.com/nodejs/node/pull/13645#issuecomment-308100452 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2017-06-10build,windows: check for VS version and archRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/13485 Fixes: https://github.com/nodejs/node/issues/13398 Reviewed-By: James M Snell <jasnell@gmail.com>
2017-06-10build: merge test suite groupsRefael Ackermann
PR-URL: https://github.com/nodejs/node/pull/13378 Refs: https://github.com/nodejs/node/pull/13340 Refs: https://github.com/nodejs/node/pull/13336 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
2017-06-02build: fix typoNikolai Vavilov
PR-URL: https://github.com/nodejs/node/pull/13396 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
2017-05-05win: make buildable on VS2017Refael Ackermann
* Set default to `vs2015` since `vs2017` is not CI-green yet * changes vcbuild.bat arg from `vc2015` to `vs2015`/`vs2017` `vc` as in Visual C++ is actually versions 14.0 or 14.10 `vs` as in Visual Studio is 2015 or 2017 Ref: http://lists.boost.org/Archives/boost/2017/03/233597.php 🤦 * keep `vc2015` for backward compatibility but "undocumented" * tools: transplant vswhere wrapper from `msvs-com-helper` Ref: https://github.com/node4good/msvs-com-helper PR-URL: https://github.com/nodejs/node/pull/11852 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
2017-05-03build: add static option to vcbuild.batTony Rice
Passes --enable-static to ./configure. PR-URL: https://github.com/nodejs/node/pull/12764 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
2017-04-30build: add target for checking for perm deoptsBrian White
PR-URL: https://github.com/nodejs/node/pull/12456 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2017-04-25doc, tools: add doc linting to CIVse Mozhet Byt
PR-URL: https://github.com/nodejs/node/pull/12640 Fixes: https://github.com/nodejs/node/issues/12635 Refs: https://github.com/nodejs/node/pull/12563 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
2017-04-25src: allow CLI args in env with NODE_OPTIONSSam Roberts
Not all CLI options are supported, those that are problematic from a security or implementation point of view are disallowed, as are ones that are inappropriate (for example, -e, -p, --i), or that only make sense when changed with code changes (such as options that change the javascript syntax or add new APIs). PR-URL: https://github.com/nodejs/node/pull/12028 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
2017-04-25doc: add eslint-plugin-markdownVse Mozhet Byt
* install eslint-plugin-markdown * add doc/.eslintrc.yaml * add `<!-- eslint-disable rule -->` or `<!-- eslint-disable -->` for the rest of problematic code * .js files in doc folder added to .eslintignore * update Makefile and vcbuild.bat PR-URL: https://github.com/nodejs/node/pull/12563 Refs: https://github.com/nodejs/node/pull/12557#issuecomment-296015032 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>