Age | Commit message (Collapse) | Author |
|
The following metadata has changed:
- v8dbg_class_UncompiledData__inferred_name__String
- Implementation was moved to Torque and required
update to gen-postmortem-metadata.py.
- Refs: https://github.com/v8/v8/commit/e4e86b53cfd028107f6d5e2c0df10d08e690da88
- v8dbg_class_SharedFunctionInfo__script_or_debug_info__Object
- Renamed to v8dbg_class_SharedFunctionInfo__script_or_debug_info__HeapObject
- Refs: https://github.com/v8/v8/commit/07fc96c0a8db2f513a5f439d69ca083c3dad0ccd
- v8dbg_type_JSRegExp__JS_REGEXP_TYPE
- Renamed to v8dbg_type_JSRegExp__JS_REG_EXP_TYPE.
- Refs: https://github.com/v8/v8/commit/61815a22bdfe94f432bf787831eafcaffedb73ef
PR-URL: https://github.com/nodejs/node/pull/30020
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
|
The following metadata has changed:
- v8dbg_class_ConsString__first__String
- Class is now generated via torque.
- Postmortem tools should use v8dbg_class_ConsString__first_offset__int
- Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9
- v8dbg_class_ConsString__second__String
- Class is now generated via torque.
- Postmortem tools should use v8dbg_class_ConsString__second_offset__int
- Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9
- v8dbg_class_SlicedString__offset__SMI
- Class is now generated via torque.
- Postmortem tools should use v8dbg_class_SlicedString__offset_offset__int
- Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9
- v8dbg_class_ThinString__actual__String
- Class is now generated via torque.
- Postmortem tools should use v8dbg_class_ThinString__actual_offset__int
- Refs: https://github.com/v8/v8/commit/14274bb16afbdd33baef3274298bb32e1a65a3b9
PR-URL: https://github.com/nodejs/node/pull/28918
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
|
|
The following metadata has changed:
- v8dbg_class_FixedTypedArrayBase__base_pointer__Object
- Field moved from FixedTypedArrayBase to JSTypedArray.
- Postmortem tools should use v8dbg_class_JSTypedArray__base_pointer__Object.
- Refs: https://github.com/v8/v8/commit/70bd7cf0ef618621c16ae3f5ba2db614ac8ef996
- v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t
- Field moved from FixedTypedArrayBase to JSTypedArray.
- Add new constant: v8dbg_class_JSTypedArray__external_pointer__uintptr_t
- Refs: https://github.com/v8/v8/commit/70bd7cf0ef618621c16ae3f5ba2db614ac8ef996
- v8dbg_class_Map__instance_descriptors_offset
- Underlying constant was renamed to kInstanceDescriptorsOffset.
- Postmortem tools should not need to update anything for this constant.
- Refs: https://github.com/v8/v8/commit/15a7e04eec8b98c0430960a966a57d1b2ea4aa76
PR-URL: https://github.com/nodejs/node/pull/28016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
|
|
This commit updates test-postmortem-metadata to provide a
more useful error message in the scenario where Node is
compiled without postmortem support.
PR-URL: https://github.com/nodejs/node/pull/27828
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
|
|
Recent changes to spawnSync (https://github.com/nodejs/node/pull/23027)
broke our V8 postmortem tests since the output from nm was larger than
the new default maxBuffer for spawnSync. Changing the maxBuffer to
Infinity fixes the issue.
PR-URL: https://github.com/nodejs/node/pull/27265
Refs: https://github.com/v8/v8/compare/7.4.288.18...7.4.288.21
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
|
Summary of changes:
- v8dbg_class_FixedTypedArrayBase__external_pointer__Object
- Type changed in https://github.com/v8/v8/commit/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8#diff-f3f182b0510ba2ee39ae87e421ff110b.
- Use v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t
- v8dbg_class_JSArrayBuffer__backing_store__Object
- Type changed in https://github.com/v8/v8/commit/f70bb59b57e2a66f165a728c1799e36ceb0e9fc8#diff-f3f182b0510ba2ee39ae87e421ff110b.
- Use v8dbg_class_JSArrayBuffer__backing_store__uintptr_t
- v8dbg_class_Map__raw_instance_descriptors__DescriptorArray
- Changed in https://github.com/v8/v8/commit/d7b08b6da2fd963ab7f74319617050329881a8c2#diff-59788e25dc5196c356894d5e1fac6425
- New constant added to V8: v8dbg_class_Map__instance_descriptors_offset
- v8dbg_PointerSizeLog2
- Changed in https://github.com/v8/v8/commit/46d1986812097f712aa7c314c8aa49ec49a33b88#diff-f3f182b0510ba2ee39ae87e421ff110b
- Refs: https://bugs.chromium.org/p/v8/issues/detail?id=8477
- Use new constants: v8dbg_SystemPointerSize, v8dbg_SystemPointerSizeLog2,
v8dbg_TaggedSize, and v8dbg_TaggedSizeLog2
PR-URL: https://github.com/nodejs/node/pull/26685
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
|
|
The V8 7.3 update requires the following adjustments to the
postmortem debugging metadata constants:
- v8dbg_prop_idx_first was removed in
https://github.com/v8/v8/commit/1ad0cd560eb8c35bbc7bda49968af1f3859425fe
- v8dbg_jsarray_buffer_was_neutered_mask was renamed to
v8dbg_jsarray_buffer_was_detached_mask in
https://github.com/v8/v8/commit/f68ee6e7e49ac33b3ba870f7287555c5dae9051e
- v8dbg_jsarray_buffer_was_neutered_shift was renamed to
v8dbg_jsarray_buffer_was_detached_shift in
https://github.com/v8/v8/commit/f68ee6e7e49ac33b3ba870f7287555c5dae9051e
- v8dbg_class_Map__instance_descriptors__DescriptorArray moved to
v8dbg_class_Map__raw_instance_descriptors__DescriptorArray and
began using ACCESSORS2 in
https://github.com/v8/v8/commit/799dfad502839b6e648741770d9dcd4f9be9e834
The following postmortem debugging constants were also impacted
by V8's introduction of ACCESSORS2, but do not need to be updated
the test:
- v8dbg_class_ThinString__actual__String changed in
https://github.com/v8/v8/commit/0f581e4b99ee923e7ebae72e64ee58999ff74b5d
- v8dbg_class_UncompiledData__inferred_name__String changed in
https://github.com/v8/v8/commit/0f581e4b99ee923e7ebae72e64ee58999ff74b5d
- v8dbg_class_JSFunction__shared__SharedFunctionInfo changed in
https://github.com/v8/v8/commit/81620900e93bf9d2c5c84346b29c0f9ec7d7b28d
- v8dbg_class_SharedFunctionInfo__function_data__Object had its
accessor removed in
https://github.com/v8/v8/commit/a55803a15d2b202562d72bb186463ca3ebef0c1c
This has been fixed in gen-postmortem-metadata.py.
PR-URL: https://github.com/nodejs/node/pull/25852
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
|
|
The V8 7.1 update requires the following adjustments to the
postmortem debugging metadata constants:
- v8dbg_class_JSArrayBuffer__byte_length__Object
Use: v8dbg_class_JSArrayBuffer__byte_length__size_t
- v8dbg_class_JSArrayBufferView__raw_byte_length__Object
Use: v8dbg_class_JSArrayBufferView__byte_length__size_t
- v8dbg_class_JSArrayBufferView__raw_byte_offset__Object
Use: v8dbg_class_JSArrayBufferView__byte_offset__size_t
- v8dbg_class_String__length__SMI
Use: v8dbg_class_String__length__int32_t
Refs: https://github.com/v8/v8/commit/5cfe1a6b121ad004ec3d73b137f84f558aac0efd
Refs: https://github.com/v8/v8/commit/c7a0049e1b70e8f455229c8a470df605ea064f70
PR-URL: https://github.com/nodejs/node/pull/23423
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
|
|
The V8 7.0 update requires the following adjustments to the
postmortem debugging metadata constants:
- v8dbg_class_SharedFunctionInfo__script__Object
Use: v8dbg_class_SharedFunctionInfo__script_or_debug_info__Object
- v8dbg_class_SharedFunctionInfo__function_identifier_or_debug_info__Object
Use: v8dbg_class_UncompiledData__inferred_name__String and
v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
Refs: https://github.com/v8/v8/commit/c941f11abddf57844e9807503df1877f6f60c94a
PR-URL: https://github.com/nodejs/node/pull/22754
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
|
The V8 6.9 update requires the following adjustments to the
postmortem debugging metadata constants:
- v8dbg_class_SharedFunctionInfo__function_identifier__Object
Use: v8dbg_class_SharedFunctionInfo__function_identifier_or_debug_info__Object
- v8dbg_class_SharedFunctionInfo__end_position__int
Use: v8dbg_class_UncompiledData__end_position__int32_t
- v8dbg_class_SharedFunctionInfo__start_position_and_type__int
Use: v8dbg_class_UncompiledData__start_position__int32_t
- v8dbg_sharedfunctioninfo_start_position_mask and
- v8dbg_sharedfunctioninfo_start_position_shift
Removed. Use: v8dbg_class_UncompiledData__start_position__int32_t
- v8dbg_scopeinfo_idx_nstacklocals has been removed
Refs: https://github.com/v8/v8/commit/39e2d97bc4d6b35be40294f06873f03b0368ce5c
Refs: https://github.com/v8/v8/commit/467eb1497e998dd73a4006cf0655fd0ca289b6f4
Refs: https://github.com/v8/v8/commit/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5
PR-URL: https://github.com/nodejs/node/pull/21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
|
This commit updates the following postmortem metadata constant:
- v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int
- Renamed: v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__uint16_t
- V8 commit: https://github.com/v8/v8/commit/53d4dfc3771dda011ba95d0f825fabb83219ff51
PR-URL: https://github.com/nodejs/node/pull/21983
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
|
This commit updates the following postmortem metadata constant:
- v8dbg_context_idx_closure
- Renamed: v8dbg_context_idx_scope_info
- V8 commit: https://github.com/v8/v8/commit/39496a95c53934ecb80d083003b4dd11056c9f20#diff-f3f182b0510ba2ee39ae87e421ff110b
Fixes: https://github.com/nodejs/node-v8/issues/59
PR-URL: https://github.com/nodejs/node/pull/21079
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
|
|
`v8-updates` holds all tests related to V8 updates, for example, testing
for postmortem metadata chages.
PR-URL: https://github.com/nodejs/node/pull/20783
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
|