summaryrefslogtreecommitdiff
path: root/test/parallel/test-fs-copyfile-respect-permissions.js
AgeCommit message (Collapse)Author
2019-04-29test: skip fs-copyfile-respect-permission if rootDaniel Bevenius
Currently, if this test is run as the root user the following failure will occur: === release test-fs-copyfile-respect-permissions === Path: parallel/test-fs-copyfile-respect-permissions assert.js:89 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Missing expected exception (check). at Object.<anonymous> (/node/test/parallel/test-fs-copyfile-respect-permissions.js:38:10) at Module._compile (internal/modules/cjs/loader.js:759:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10) at Module.load (internal/modules/cjs/loader.js:628:32) at Function.Module._load (internal/modules/cjs/loader.js:555:12) at Function.Module.runMain (internal/modules/cjs/loader.js:826:10) at internal/main/run_main_module.js:17:11 Command: out/Release/node test/parallel/test-fs-copyfile-respect-permissions.js [05:41|% 100|+ 2620|- 1]: Done This commit adds a root user check and skips this test if running as the user root. PR-URL: https://github.com/nodejs/node/pull/27378 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
2019-04-22test: move known issue test to parallelcjihrig
As of libuv 1.28.0, this bug is fixed, and the test can be moved to parallel. This commit also updates an error code check to work on Windows. PR-URL: https://github.com/nodejs/node/pull/27241 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>