summaryrefslogtreecommitdiff
path: root/.github/PULL_REQUEST_TEMPLATE.md
AgeCommit message (Collapse)Author
2019-08-26doc: add dco to github pr templateMyles Borins
Our project relies on the Developer Certificate of Origin as a passive alternative to a Contributor License Agreement. The PR template seems like a great place to surface the text to help new contributors be aware of the DCO and it's implications. PR-URL: https://github.com/nodejs/node/pull/24023 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
2018-03-06doc: remove subsystem from pull request templateRich Trott
Remove request that user provide a list of subsystems in the pull request template. * We already ask them to put the subsystems in the first line of the commit message. * The subsystem is usually easy to determine. * We have a bot that applies subsystem labels on new PRs and it seems to do a rather good job. Tools over rules. Let the bot do it. * The fewer unnecessary things we ask for in the template, the lower the barrier to entry. * Anecdotal, but I have never found it useful to have the person submitting the PR list out subsystems in the pull request post. PR-URL: https://github.com/nodejs/node/pull/19125 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matheus Marchini <matheus@sthima.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
2018-01-24doc: split CONTRIBUTING.mdJoyee Cheung
PR-URL: https://github.com/nodejs/node/pull/18271 Fixes: https://github.com/nodejs/node/issues/17842 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2017-05-05doc: fix commit guideline urlThomas Watson
PR-URL: https://github.com/nodejs/node/pull/12862 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
2017-04-05doc: update pull request template URL layoutRich Trott
Putting the link for the commit guideline at the bottom of the pull request template makes it a bit confusing when opening a pull request as the markdown does not render. Not everyone is familiar with the syntax used there and it is easy to mess it up (for example, by not leaving a blank line above it). It is more natural and useful if the URL is included inline. PR-URL: https://github.com/nodejs/node/pull/12216 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2017-03-16doc: linkable commit message guidelinesSam Roberts
Put the commit guidelines themselves under a heading to be more prominent, and to allow linking directly to them (instead of the section on how to use git). Link the pull request template to the guidelines, so contributors can find them. PR-URL: https://github.com/nodejs/node/pull/11792 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-12-29meta: modify pull request template for prependingRich Trott
The GitHub interface for new pull requests has started prepending commit messages for single-commit pull requests. It had previously been appending them. Modify the GitHub template to accommodate the new behavior. PR-URL: https://github.com/nodejs/node/pull/10484 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
2016-12-18build: change nosign flag to sign and flips logicJoe Doyle
Makes the default build on Windows not try to sign the node.exe binary after a build. Instead the 'sign' flag now indicates that the binary should be signed. The 'nosign' flag is left as a noop. Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> PR-URL: https://github.com/nodejs/node/pull/10156
2016-12-09doc: standardizing on make -j4Jonathan Darling
Standardizes docs to use -j4 instead of -j8 as it appears to be the most inclusive recommendation based on discussion in https://github.com/nodejs/node/pull/9961. PR-URL: https://github.com/nodejs/node/pull/9961 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2016-09-22doc: standardize on `make -j8`Rich Trott
Most of the docs recommend `make -j8`. The one exception is the pull request template which recommends `make -j4`. This changes the pull request template so that it is in line with the other docs. PR-URL: https://github.com/nodejs/node/pull/8678 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
2016-06-27doc: minor rewording to the GitHub issue/pr templatesJeremiah Senkpiel
- Templates are now a bit more consistent with phrasing. - Simplified a bit. PR-URL: https://github.com/nodejs/node/pull/7403 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
2016-06-10doc: make pull request template more conciseRich Trott
PR-URL: https://github.com/nodejs/node/pull/7239 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
2016-06-06doc: consolidate test/lint text in GH PR templateRich Trott
PR-URL: https://github.com/nodejs/node/pull/7155 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2016-06-01doc: edit pull request templateRich Trott
Move checklist instructions closer to the checklist. Trim unnecessary words. PR-URL: https://github.com/nodejs/node/pull/7058 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
2016-05-16doc: trim GitHub template commentsRich Trott
Make the comments in the GitHub templates slightly more concise. PR-URL: https://github.com/nodejs/node/pull/6755 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
2016-04-06doc: improve github templates by using commentsJohan Bergström
Use HTML comments to reduce potential noise in github templates. Also, improve flow of the pull request, making it easier to read. PR-URL: https://github.com/nodejs/node/pull/5710 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
2016-02-23github: put description of PR to the end of tmplFedor Indutny
It looks like github appends commit log right after the template contents. Seeing this it does not look logical to ask for details first. This commit puts `Description of change` part to the end of the template. PR-URL: https://github.com/nodejs/node/pull/5378 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
2016-02-23github: add issue and pull request templatesFedor Indutny
Fix: #5246 PR-URL: https://github.com/nodejs/node/pull/5291 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Steven R. Loomis <srloomis@us.ibm.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-13 04:18:46 +0000