diff options
Diffstat (limited to 'doc/onboarding.md')
-rw-r--r-- | doc/onboarding.md | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/doc/onboarding.md b/doc/onboarding.md index 3a03edb17e..bd9418fd91 100644 --- a/doc/onboarding.md +++ b/doc/onboarding.md @@ -138,8 +138,7 @@ onboarding session. * There is a minimum waiting time which we try to respect for non-trivial changes so that people who may have important input in such a distributed project are able to respond. - * For non-trivial changes, leave the pull request open for at least 48 hours - (72 hours on a weekend). + * For non-trivial changes, leave the pull request open for at least 72 hours. * If a pull request is abandoned, check if they'd mind if you took it over (especially if it just has nits left). * Approving a change @@ -215,7 +214,7 @@ needs to be pointed out separately during the onboarding. * Run CI on the PR. Because the PR does not affect any code, use the `node-test-pull-request-lite-pipeline` CI task. * After one or two approvals, land the PR (PRs of this type do not need to wait - for 48/72 hours to land). + for 72 hours to land). * Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` metadata. * [`node-core-utils`][] automates the generation of metadata and the landing |