diff options
Diffstat (limited to 'deps/v8/src/debug/debug.cc')
-rw-r--r-- | deps/v8/src/debug/debug.cc | 17 |
1 files changed, 8 insertions, 9 deletions
diff --git a/deps/v8/src/debug/debug.cc b/deps/v8/src/debug/debug.cc index aa308150ac..27f30d8c05 100644 --- a/deps/v8/src/debug/debug.cc +++ b/deps/v8/src/debug/debug.cc @@ -622,9 +622,7 @@ bool Debug::SetBreakPointForScript(Handle<Script> script, Handle<BreakPoint> break_point = isolate_->factory()->NewBreakPoint(*id, condition); if (script->type() == Script::TYPE_WASM) { - Handle<WasmModuleObject> module_object( - WasmModuleObject::cast(script->wasm_module_object()), isolate_); - return WasmModuleObject::SetBreakPoint(module_object, source_position, + return WasmModuleObject::SetBreakPoint(script, source_position, break_point); } @@ -1039,7 +1037,7 @@ void Debug::PrepareStep(StepAction step_action) { // and deoptimize every frame along the way. bool in_current_frame = true; for (; !frames_it.done(); frames_it.Advance()) { - // TODO(clemensh): Implement stepping out from JS to wasm. + // TODO(clemensb): Implement stepping out from JS to wasm. if (frames_it.frame()->is_wasm()) continue; JavaScriptFrame* frame = JavaScriptFrame::cast(frames_it.frame()); if (last_step_action() == StepIn) { @@ -1069,7 +1067,7 @@ void Debug::PrepareStep(StepAction step_action) { thread_local_.target_frame_count_ = current_frame_count; V8_FALLTHROUGH; case StepIn: - // TODO(clemensh): Implement stepping from JS into wasm. + // TODO(clemensb): Implement stepping from JS into wasm. FloodWithOneShot(shared); break; } @@ -1171,7 +1169,7 @@ void Debug::PrepareFunctionForDebugExecution( if (debug_info->flags() & DebugInfo::kPreparedForDebugExecution) return; // Make a copy of the bytecode array if available. - Handle<Object> maybe_original_bytecode_array = + Handle<HeapObject> maybe_original_bytecode_array = isolate_->factory()->undefined_value(); if (shared->HasBytecodeArray()) { Handle<BytecodeArray> original_bytecode_array = @@ -1250,7 +1248,7 @@ void Debug::InstallDebugBreakTrampoline() { JSObject object = JSObject::cast(obj); DescriptorArray descriptors = object.map().instance_descriptors(); - for (int i = 0; i < object.map().NumberOfOwnDescriptors(); ++i) { + for (InternalIndex i : object.map().IterateOwnDescriptors()) { if (descriptors.GetDetails(i).kind() == PropertyKind::kAccessor) { Object value = descriptors.GetStrongValue(i); if (!value.IsAccessorPair()) continue; @@ -1901,6 +1899,7 @@ bool Debug::CanBreakAtEntry(Handle<SharedFunctionInfo> shared) { bool Debug::SetScriptSource(Handle<Script> script, Handle<String> source, bool preview, debug::LiveEditResult* result) { DebugScope debug_scope(this); + feature_tracker()->Track(DebugFeatureTracker::kLiveEdit); running_live_edit_ = true; LiveEdit::PatchScript(isolate_, script, source, preview, result); running_live_edit_ = false; @@ -1968,11 +1967,11 @@ void Debug::UpdateState() { if (is_active) { // Note that the debug context could have already been loaded to // bootstrap test cases. - isolate_->compilation_cache()->Disable(); + isolate_->compilation_cache()->DisableScriptAndEval(); is_active = true; feature_tracker()->Track(DebugFeatureTracker::kActive); } else { - isolate_->compilation_cache()->Enable(); + isolate_->compilation_cache()->EnableScriptAndEval(); Unload(); } is_active_ = is_active; |