summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--lib/inspector.js2
-rw-r--r--lib/internal/bootstrap/loaders.js1
-rw-r--r--lib/internal/console/inspector.js2
-rw-r--r--lib/internal/inspector_async_hook.js2
-rw-r--r--lib/internal/modules/cjs/helpers.js2
-rw-r--r--lib/internal/modules/cjs/loader.js2
-rw-r--r--lib/internal/modules/esm/module_job.js2
-rw-r--r--lib/internal/process/coverage.js2
-rw-r--r--src/inspector_js_api.cc2
-rw-r--r--src/node.cc2
-rw-r--r--test/parallel/test-process-binding-internalbinding-whitelist.js1
-rw-r--r--test/sequential/test-async-wrap-getasyncid.js2
12 files changed, 12 insertions, 10 deletions
diff --git a/lib/inspector.js b/lib/inspector.js
index 14ea01e6ad..aac864901c 100644
--- a/lib/inspector.js
+++ b/lib/inspector.js
@@ -11,7 +11,7 @@ const {
} = require('internal/errors').codes;
const { validateString } = require('internal/validators');
const util = require('util');
-const { Connection, open, url } = process.binding('inspector');
+const { Connection, open, url } = internalBinding('inspector');
if (!Connection)
throw new ERR_INSPECTOR_NOT_AVAILABLE();
diff --git a/lib/internal/bootstrap/loaders.js b/lib/internal/bootstrap/loaders.js
index c37176a5a8..c33072560a 100644
--- a/lib/internal/bootstrap/loaders.js
+++ b/lib/internal/bootstrap/loaders.js
@@ -90,6 +90,7 @@ const internalBindingWhitelist = [
'fs_event_wrap',
'http_parser',
'icu',
+ 'inspector',
'js_stream',
'natives',
'pipe_wrap',
diff --git a/lib/internal/console/inspector.js b/lib/internal/console/inspector.js
index 5e04289be9..d481896e8a 100644
--- a/lib/internal/console/inspector.js
+++ b/lib/internal/console/inspector.js
@@ -4,7 +4,7 @@ const path = require('path');
const CJSModule = require('internal/modules/cjs/loader');
const { makeRequireFunction } = require('internal/modules/cjs/helpers');
const { tryGetCwd } = require('internal/util');
-const { addCommandLineAPI, consoleCall } = process.binding('inspector');
+const { addCommandLineAPI, consoleCall } = internalBinding('inspector');
// Wrap a console implemented by Node.js with features from the VM inspector
function addInspectorApis(consoleFromNode, consoleFromVM) {
diff --git a/lib/internal/inspector_async_hook.js b/lib/internal/inspector_async_hook.js
index 1ad0cbf3a5..4a3d31fc2a 100644
--- a/lib/internal/inspector_async_hook.js
+++ b/lib/internal/inspector_async_hook.js
@@ -1,6 +1,6 @@
'use strict';
-const inspector = process.binding('inspector');
+const inspector = internalBinding('inspector');
if (!inspector || !inspector.asyncTaskScheduled) {
exports.setup = function() {};
diff --git a/lib/internal/modules/cjs/helpers.js b/lib/internal/modules/cjs/helpers.js
index 2c856a99c6..fcb536c3df 100644
--- a/lib/internal/modules/cjs/helpers.js
+++ b/lib/internal/modules/cjs/helpers.js
@@ -108,7 +108,7 @@ if (getOptionValue('--experimental-worker')) {
builtinLibs.sort();
}
-if (typeof process.binding('inspector').open === 'function') {
+if (typeof internalBinding('inspector').open === 'function') {
builtinLibs.push('inspector');
builtinLibs.sort();
}
diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
index 91d32ea2d0..ee4fffa64a 100644
--- a/lib/internal/modules/cjs/loader.js
+++ b/lib/internal/modules/cjs/loader.js
@@ -703,7 +703,7 @@ Module.prototype._compile = function(content, filename) {
// Set breakpoint on module start
if (filename === resolvedArgv) {
delete process._breakFirstLine;
- inspectorWrapper = process.binding('inspector').callAndPauseOnStart;
+ inspectorWrapper = internalBinding('inspector').callAndPauseOnStart;
}
}
var dirname = path.dirname(filename);
diff --git a/lib/internal/modules/esm/module_job.js b/lib/internal/modules/esm/module_job.js
index 50aa00a09a..fbb29aef78 100644
--- a/lib/internal/modules/esm/module_job.js
+++ b/lib/internal/modules/esm/module_job.js
@@ -73,7 +73,7 @@ class ModuleJob {
try {
if (this.isMain && process._breakFirstLine) {
delete process._breakFirstLine;
- const initWrapper = process.binding('inspector').callAndPauseOnStart;
+ const initWrapper = internalBinding('inspector').callAndPauseOnStart;
initWrapper(this.module.instantiate, this.module);
} else {
this.module.instantiate();
diff --git a/lib/internal/process/coverage.js b/lib/internal/process/coverage.js
index 9c9b2b4711..5c5d0c2b61 100644
--- a/lib/internal/process/coverage.js
+++ b/lib/internal/process/coverage.js
@@ -51,7 +51,7 @@ function disableAllAsyncHooks() {
exports.writeCoverage = writeCoverage;
function setup() {
- const { Connection } = process.binding('inspector');
+ const { Connection } = internalBinding('inspector');
if (!Connection) {
console.warn('inspector not enabled');
return;
diff --git a/src/inspector_js_api.cc b/src/inspector_js_api.cc
index f12cc3fb5a..0bf43c6fbb 100644
--- a/src/inspector_js_api.cc
+++ b/src/inspector_js_api.cc
@@ -315,5 +315,5 @@ void Initialize(Local<Object> target, Local<Value> unused,
} // namespace inspector
} // namespace node
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector,
+NODE_MODULE_CONTEXT_AWARE_INTERNAL(inspector,
node::inspector::Initialize);
diff --git a/src/node.cc b/src/node.cc
index f24ba12a81..7e1a904e52 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -2145,5 +2145,5 @@ int Start(int argc, char** argv) {
#if !HAVE_INSPECTOR
void Initialize() {}
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(inspector, Initialize)
+NODE_MODULE_CONTEXT_AWARE_INTERNAL(inspector, Initialize)
#endif // !HAVE_INSPECTOR
diff --git a/test/parallel/test-process-binding-internalbinding-whitelist.js b/test/parallel/test-process-binding-internalbinding-whitelist.js
index 3eb87e2f0f..dafac94769 100644
--- a/test/parallel/test-process-binding-internalbinding-whitelist.js
+++ b/test/parallel/test-process-binding-internalbinding-whitelist.js
@@ -17,3 +17,4 @@ assert(process.binding('spawn_sync'));
assert(process.binding('js_stream'));
assert(process.binding('buffer'));
assert(process.binding('fs'));
+assert(process.binding('inspector'));
diff --git a/test/sequential/test-async-wrap-getasyncid.js b/test/sequential/test-async-wrap-getasyncid.js
index 2ad602e482..6a6bf1b407 100644
--- a/test/sequential/test-async-wrap-getasyncid.js
+++ b/test/sequential/test-async-wrap-getasyncid.js
@@ -291,7 +291,7 @@ if (common.hasCrypto) { // eslint-disable-line node-core/crypto-check
if (process.config.variables.v8_enable_inspector !== 0 &&
common.isMainThread) {
- const binding = process.binding('inspector');
+ const binding = internalBinding('inspector');
const handle = new binding.Connection(() => {});
testInitialized(handle, 'Connection');
handle.disconnect();