diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2019-07-03 17:24:33 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-07-20 11:10:28 +0200 |
| commit | b4aa7d357022383ae1256b6d5a42498119cb4018 (patch) | |
| tree | c8b88da4f6e51ca9b53e214e4d8584f8ba1f08b8 /tools | |
| parent | 4b9d4193e1612774f51d6ccd4baa12651d3f44bd (diff) | |
| download | android-node-v8-b4aa7d357022383ae1256b6d5a42498119cb4018.tar.gz android-node-v8-b4aa7d357022383ae1256b6d5a42498119cb4018.tar.bz2 android-node-v8-b4aa7d357022383ae1256b6d5a42498119cb4018.zip | |
build: remove broken intel vtune support
Support for VTune profiling was added in commit a881b53 from November
2015 but has since bitrotted. Remove it.
Fixes: https://github.com/nodejs/node/issues/28310
Refs: https://github.com/nodejs/node/pull/3785
PR-URL: https://github.com/nodejs/node/pull/28522
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/v8_gypfiles/broken/v8vtune.gyp | 36 | ||||
| -rw-r--r-- | tools/v8_gypfiles/d8.gyp | 7 | ||||
| -rw-r--r-- | tools/v8_gypfiles/features.gypi | 6 |
3 files changed, 0 insertions, 49 deletions
diff --git a/tools/v8_gypfiles/broken/v8vtune.gyp b/tools/v8_gypfiles/broken/v8vtune.gyp deleted file mode 100644 index 2a756d4b80..0000000000 --- a/tools/v8_gypfiles/broken/v8vtune.gyp +++ /dev/null @@ -1,36 +0,0 @@ -# Copyright 2012 the V8 project authors. All rights reserved. -# Use of this source code is governed by a BSD-style license that can be -# found in the LICENSE file. - -{ - 'variables': { - 'v8_code': 1, - }, - 'includes': ['toolchain.gypi', 'features.gypi'], - 'targets': [ - { - 'target_name': 'v8_vtune', - 'type': 'static_library', - 'dependencies': [ - 'v8.gyp:v8', - ], - 'sources': [ - '../src/third_party/vtune/ittnotify_config.h', - '../src/third_party/vtune/ittnotify_types.h', - '../src/third_party/vtune/jitprofiling.cc', - '../src/third_party/vtune/jitprofiling.h', - '../src/third_party/vtune/v8-vtune.h', - '../src/third_party/vtune/vtune-jit.cc', - '../src/third_party/vtune/vtune-jit.h', - ], - 'direct_dependent_settings': { - 'defines': ['ENABLE_VTUNE_JIT_INTERFACE',], - 'conditions': [ - ['OS != "win"', { - 'libraries': ['-ldl',], - }], - ], - }, - }, - ], -} diff --git a/tools/v8_gypfiles/d8.gyp b/tools/v8_gypfiles/d8.gyp index a5fc10113f..240df03380 100644 --- a/tools/v8_gypfiles/d8.gyp +++ b/tools/v8_gypfiles/d8.gyp @@ -5,8 +5,6 @@ { 'variables': { 'v8_code': 1, - # Enable support for Intel VTune. Supported on ia32/x64 only - 'v8_enable_vtunejit%': 0, 'v8_enable_i18n_support%': 1, }, 'includes': ['toolchain.gypi', 'features.gypi'], @@ -62,11 +60,6 @@ }], ], }], - ['v8_enable_vtunejit==1', { - 'dependencies': [ - 'v8vtune.gyp:v8_vtune', - ], - }], ['v8_enable_i18n_support==1', { 'dependencies': [ '<(icu_gyp_path):icui18n', diff --git a/tools/v8_gypfiles/features.gypi b/tools/v8_gypfiles/features.gypi index 23dd84a49d..570c6ace90 100644 --- a/tools/v8_gypfiles/features.gypi +++ b/tools/v8_gypfiles/features.gypi @@ -102,9 +102,6 @@ # Sets -dENABLE_GDB_JIT_INTERFACE. 'v8_enable_gdbjit%': 0, - # Sets -dENABLE_VTUNE_JIT_INTERFACE. - 'v8_enable_vtunejit%': 0, - # Currently set for node by common.gypi, avoiding default because of gyp file bug. # Should be turned on only for debugging. #'v8_enable_handle_zapping%': 0, @@ -225,9 +222,6 @@ ['v8_enable_gdbjit==1', { 'defines': ['ENABLE_GDB_JIT_INTERFACE',], }], - ['v8_enable_vtunejit==1', { - 'defines': ['ENABLE_VTUNE_JIT_INTERFACE',], - }], ['v8_enable_minor_mc==1', { 'defines': ['ENABLE_MINOR_MC',], }], |