diff options
| author | cjihrig <cjihrig@gmail.com> | 2019-07-21 00:15:32 -0400 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-07-23 08:15:42 +0200 |
| commit | ed43880d6ba1ab6e499ef027c1e9e11a2376ba50 (patch) | |
| tree | bd9551f12adfd0dc9f333adf306fc92f2417b2ad /tools/node_modules/eslint/lib/rules/prefer-const.js | |
| parent | 302865e8b9756812b45d9ff60403c2a231c01152 (diff) | |
| download | android-node-v8-ed43880d6ba1ab6e499ef027c1e9e11a2376ba50.tar.gz android-node-v8-ed43880d6ba1ab6e499ef027c1e9e11a2376ba50.tar.bz2 android-node-v8-ed43880d6ba1ab6e499ef027c1e9e11a2376ba50.zip | |
tools: update ESLint to 6.1.0
Update ESLint to 6.1.0
PR-URL: https://github.com/nodejs/node/pull/28793
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Diffstat (limited to 'tools/node_modules/eslint/lib/rules/prefer-const.js')
| -rw-r--r-- | tools/node_modules/eslint/lib/rules/prefer-const.js | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/tools/node_modules/eslint/lib/rules/prefer-const.js b/tools/node_modules/eslint/lib/rules/prefer-const.js index 68c07da4ed..854da310e4 100644 --- a/tools/node_modules/eslint/lib/rules/prefer-const.js +++ b/tools/node_modules/eslint/lib/rules/prefer-const.js @@ -420,8 +420,9 @@ module.exports = { let shouldFix = varDeclParent && - // Don't do a fix unless the variable is initialized (or it's in a for-in or for-of loop) - (varDeclParent.parent.type === "ForInStatement" || varDeclParent.parent.type === "ForOfStatement" || varDeclParent.declarations[0].init) && + // Don't do a fix unless all variables in the declarations are initialized (or it's in a for-in or for-of loop) + (varDeclParent.parent.type === "ForInStatement" || varDeclParent.parent.type === "ForOfStatement" || + varDeclParent.declarations.every(declaration => declaration.init)) && /* * If options.destructuring is "all", then this warning will not occur unless @@ -450,7 +451,12 @@ module.exports = { node, messageId: "useConst", data: node, - fix: shouldFix ? fixer => fixer.replaceText(sourceCode.getFirstToken(varDeclParent), "const") : null + fix: shouldFix + ? fixer => fixer.replaceText( + sourceCode.getFirstToken(varDeclParent, t => t.value === varDeclParent.kind), + "const" + ) + : null }); }); } |