test: s/assert.equal/assert.strictEqual/

Use assert.strictEqual instead of assert.equal in tests, manually
convert types where necessary.

PR-URL: https://github.com/nodejs/node/pull/10698
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>

1 files changed, 54 insertions, 47 deletions

diff --git a/test/parallel/test-readline-interface.js b/test/parallel/test-readline-interface.js
index e8fc92ad1c..53c132dc30 100644
--- a/test/parallel/test-readline-interface.js
+++ b/test/parallel/test-readline-interface.js
@@ -84,7 +84,7 @@ function isWarned(emitter) {
   called = false;
   rli.on('line', function(line) {
     called = true;
-    assert.equal(line, 'asdf');
+    assert.strictEqual(line, 'asdf');
   });
   fi.emit('data', 'asdf\n');
   assert.ok(called);
@@ -95,7 +95,7 @@ function isWarned(emitter) {
   called = false;
   rli.on('line', function(line) {
     called = true;
-    assert.equal(line, '');
+    assert.strictEqual(line, '');
   });
   fi.emit('data', '\n');
   assert.ok(called);
@@ -117,7 +117,7 @@ function isWarned(emitter) {
   called = false;
   rli.on('line', function(line) {
     called = true;
-    assert.equal(line, 'a');
+    assert.strictEqual(line, 'a');
   });
   fi.emit('data', 'a');
   assert.ok(!called);
@@ -131,11 +131,11 @@ function isWarned(emitter) {
   let expectedLines = ['foo', 'bar', 'baz'];
   let callCount = 0;
   rli.on('line', function(line) {
-    assert.equal(line, expectedLines[callCount]);
+    assert.strictEqual(line, expectedLines[callCount]);
     callCount++;
   });
   fi.emit('data', expectedLines.join('\n') + '\n');
-  assert.equal(callCount, expectedLines.length);
+  assert.strictEqual(callCount, expectedLines.length);
   rli.close();
 
   // sending multiple newlines at once that does not end with a new line
@@ -144,11 +144,11 @@ function isWarned(emitter) {
   expectedLines = ['foo', 'bar', 'baz', 'bat'];
   callCount = 0;
   rli.on('line', function(line) {
-    assert.equal(line, expectedLines[callCount]);
+    assert.strictEqual(line, expectedLines[callCount]);
     callCount++;
   });
   fi.emit('data', expectedLines.join('\n'));
-  assert.equal(callCount, expectedLines.length - 1);
+  assert.strictEqual(callCount, expectedLines.length - 1);
   rli.close();
 
   // sending multiple newlines at once that does not end with a new(empty)
@@ -158,7 +158,7 @@ function isWarned(emitter) {
   expectedLines = ['foo', 'bar', 'baz', ''];
   callCount = 0;
   rli.on('line', function(line) {
-    assert.equal(line, expectedLines[callCount]);
+    assert.strictEqual(line, expectedLines[callCount]);
     callCount++;
   });
   rli.on('close', function() {
@@ -166,7 +166,7 @@ function isWarned(emitter) {
   });
   fi.emit('data', expectedLines.join('\n'));
   fi.emit('end');
-  assert.equal(callCount, expectedLines.length);
+  assert.strictEqual(callCount, expectedLines.length);
   rli.close();
 
   // sending multiple newlines at once that does not end with a new line
@@ -178,11 +178,11 @@ function isWarned(emitter) {
   expectedLines = ['foo', 'bar', 'baz', 'bat'];
   callCount = 0;
   rli.on('line', function(line) {
-    assert.equal(line, expectedLines[callCount]);
+    assert.strictEqual(line, expectedLines[callCount]);
     callCount++;
   });
   fi.emit('data', expectedLines.join('\r\n'));
-  assert.equal(callCount, expectedLines.length - 1);
+  assert.strictEqual(callCount, expectedLines.length - 1);
   rli.close();
 
   // \r\n should emit one line event when split across multiple writes.
@@ -191,14 +191,14 @@ function isWarned(emitter) {
   expectedLines = ['foo', 'bar', 'baz', 'bat'];
   callCount = 0;
   rli.on('line', function(line) {
-    assert.equal(line, expectedLines[callCount]);
+    assert.strictEqual(line, expectedLines[callCount]);
     callCount++;
   });
   expectedLines.forEach(function(line) {
     fi.emit('data', line + '\r');
     fi.emit('data', '\n');
   });
-  assert.equal(callCount, expectedLines.length);
+  assert.strictEqual(callCount, expectedLines.length);
   rli.close();
 
   // \r should behave like \n when alone
@@ -207,11 +207,11 @@ function isWarned(emitter) {
   expectedLines = ['foo', 'bar', 'baz', 'bat'];
   callCount = 0;
   rli.on('line', function(line) {
-    assert.equal(line, expectedLines[callCount]);
+    assert.strictEqual(line, expectedLines[callCount]);
     callCount++;
   });
   fi.emit('data', expectedLines.join('\r'));
-  assert.equal(callCount, expectedLines.length - 1);
+  assert.strictEqual(callCount, expectedLines.length - 1);
   rli.close();
 
   // \r at start of input should output blank line
@@ -220,11 +220,11 @@ function isWarned(emitter) {
   expectedLines = ['', 'foo' ];
   callCount = 0;
   rli.on('line', function(line) {
-    assert.equal(line, expectedLines[callCount]);
+    assert.strictEqual(line, expectedLines[callCount]);
     callCount++;
   });
   fi.emit('data', '\rfoo\r');
-  assert.equal(callCount, expectedLines.length);
+  assert.strictEqual(callCount, expectedLines.length);
   rli.close();
 
   // Emit two line events when the delay
@@ -245,7 +245,7 @@ function isWarned(emitter) {
     fi.emit('data', '\r');
     setTimeout(common.mustCall(() => {
       fi.emit('data', '\n');
-      assert.equal(callCount, 2);
+      assert.strictEqual(callCount, 2);
       rli.close();
     }), delay * 2);
   }
@@ -256,7 +256,7 @@ function isWarned(emitter) {
   rli = new readline.Interface({ input: fi, output: fi, terminal: true });
   called = false;
   rli.on('line', function(line) {
-    assert.equal(line, '\t');
+    assert.strictEqual(line, '\t');
     assert.strictEqual(called, false);
     called = true;
   });
@@ -278,7 +278,7 @@ function isWarned(emitter) {
   });
   called = false;
   rli.on('line', function(line) {
-    assert.equal(line, 'foo');
+    assert.strictEqual(line, 'foo');
     assert.strictEqual(called, false);
     called = true;
   });
@@ -312,14 +312,14 @@ function isWarned(emitter) {
   callCount = 0;
   rli.on('line', function(line) {
     callCount++;
-    assert.equal(line, buf.toString('utf8'));
+    assert.strictEqual(line, buf.toString('utf8'));
   });
   [].forEach.call(buf, function(i) {
     fi.emit('data', Buffer.from([i]));
   });
-  assert.equal(callCount, 0);
+  assert.strictEqual(callCount, 0);
   fi.emit('data', '\n');
-  assert.equal(callCount, 1);
+  assert.strictEqual(callCount, 1);
   rli.close();
 
   // Regression test for repl freeze, #1968:
@@ -337,7 +337,7 @@ function isWarned(emitter) {
     fi.emit('data', 'fooX');
   } catch (e) { }
   fi.emit('data', 'bar');
-  assert.equal(keys.join(''), 'fooXbar');
+  assert.strictEqual(keys.join(''), 'fooXbar');
   rli.close();
 
   // calling readline without `new`
@@ -346,7 +346,7 @@ function isWarned(emitter) {
   called = false;
   rli.on('line', function(line) {
     called = true;
-    assert.equal(line, 'asdf');
+    assert.strictEqual(line, 'asdf');
   });
   fi.emit('data', 'asdf\n');
   assert.ok(called);
@@ -361,8 +361,8 @@ function isWarned(emitter) {
       rli.close();
     });
     let cursorPos = rli._getCursorPos();
-    assert.equal(cursorPos.rows, 0);
-    assert.equal(cursorPos.cols, expectedLines[0].length);
+    assert.strictEqual(cursorPos.rows, 0);
+    assert.strictEqual(cursorPos.cols, expectedLines[0].length);
     rli.close();
 
     // sending a multi-line question
@@ -373,8 +373,8 @@ function isWarned(emitter) {
       rli.close();
     });
     cursorPos = rli._getCursorPos();
-    assert.equal(cursorPos.rows, expectedLines.length - 1);
-    assert.equal(cursorPos.cols, expectedLines.slice(-1)[0].length);
+    assert.strictEqual(cursorPos.rows, expectedLines.length - 1);
+    assert.strictEqual(cursorPos.cols, expectedLines.slice(-1)[0].length);
     rli.close();
   }
 
@@ -384,17 +384,21 @@ function isWarned(emitter) {
   });
 
   // wide characters should be treated as two columns.
-  assert.equal(internalReadline.isFullWidthCodePoint('a'.charCodeAt(0)), false);
-  assert.equal(internalReadline.isFullWidthCodePoint('あ'.charCodeAt(0)), true);
-  assert.equal(internalReadline.isFullWidthCodePoint('谢'.charCodeAt(0)), true);
-  assert.equal(internalReadline.isFullWidthCodePoint('고'.charCodeAt(0)), true);
-  assert.equal(internalReadline.isFullWidthCodePoint(0x1f251), true);
-  assert.equal(internalReadline.getStringWidth('abcde'), 5);
-  assert.equal(internalReadline.getStringWidth('古池や'), 6);
-  assert.equal(internalReadline.getStringWidth('ノード.js'), 9);
-  assert.equal(internalReadline.getStringWidth('你好'), 4);
-  assert.equal(internalReadline.getStringWidth('안녕하세요'), 10);
-  assert.equal(internalReadline.getStringWidth('A\ud83c\ude00BC'), 5);
+  assert.strictEqual(internalReadline.isFullWidthCodePoint('a'.charCodeAt(0)),
+                     false);
+  assert.strictEqual(internalReadline.isFullWidthCodePoint('あ'.charCodeAt(0)),
+                     true);
+  assert.strictEqual(internalReadline.isFullWidthCodePoint('谢'.charCodeAt(0)),
+                     true);
+  assert.strictEqual(internalReadline.isFullWidthCodePoint('고'.charCodeAt(0)),
+                     true);
+  assert.strictEqual(internalReadline.isFullWidthCodePoint(0x1f251), true);
+  assert.strictEqual(internalReadline.getStringWidth('abcde'), 5);
+  assert.strictEqual(internalReadline.getStringWidth('古池や'), 6);
+  assert.strictEqual(internalReadline.getStringWidth('ノード.js'), 9);
+  assert.strictEqual(internalReadline.getStringWidth('你好'), 4);
+  assert.strictEqual(internalReadline.getStringWidth('안녕하세요'), 10);
+  assert.strictEqual(internalReadline.getStringWidth('A\ud83c\ude00BC'), 5);
 
   // check if vt control chars are stripped
   assert.strictEqual(
@@ -413,10 +417,13 @@ function isWarned(emitter) {
     internalReadline.stripVTControlCharacters('> '),
     '> '
   );
-  assert.equal(internalReadline.getStringWidth('\u001b[31m> \u001b[39m'), 2);
-  assert.equal(internalReadline.getStringWidth('\u001b[31m> \u001b[39m> '), 4);
-  assert.equal(internalReadline.getStringWidth('\u001b[31m\u001b[39m'), 0);
-  assert.equal(internalReadline.getStringWidth('> '), 2);
+  assert.strictEqual(internalReadline
+    .getStringWidth('\u001b[31m> \u001b[39m'), 2);
+  assert.strictEqual(internalReadline
+    .getStringWidth('\u001b[31m> \u001b[39m> '), 4);
+  assert.strictEqual(internalReadline
+    .getStringWidth('\u001b[31m\u001b[39m'), 0);
+  assert.strictEqual(internalReadline.getStringWidth('> '), 2);
 
   assert.deepStrictEqual(fi.listeners(terminal ? 'keypress' : 'data'), []);
 
@@ -427,8 +434,8 @@ function isWarned(emitter) {
       output: process.stdout
     });
     rl.close();
-    assert.equal(isWarned(process.stdin._events), false);
-    assert.equal(isWarned(process.stdout._events), false);
+    assert.strictEqual(isWarned(process.stdin._events), false);
+    assert.strictEqual(isWarned(process.stdout._events), false);
   }
 
   //can create a new readline Interface with a null output arugument
@@ -438,7 +445,7 @@ function isWarned(emitter) {
   called = false;
   rli.on('line', function(line) {
     called = true;
-    assert.equal(line, 'asdf');
+    assert.strictEqual(line, 'asdf');
   });
   fi.emit('data', 'asdf\n');
   assert.ok(called);