diff options
author | Sam Roberts <vieuxtech@gmail.com> | 2018-12-19 13:57:27 -0800 |
---|---|---|
committer | Sam Roberts <vieuxtech@gmail.com> | 2018-12-28 12:57:24 -0800 |
commit | 08387b245ecfe5fb736d2d6753b880e644a4f3e2 (patch) | |
tree | ea58e31bb3b20b18a07807fa8cb03a9e6e3b29dc /src/node_crypto_clienthello.cc | |
parent | acb49dc04d3700398f58fec2011661383077b638 (diff) | |
download | android-node-v8-08387b245ecfe5fb736d2d6753b880e644a4f3e2.tar.gz android-node-v8-08387b245ecfe5fb736d2d6753b880e644a4f3e2.tar.bz2 android-node-v8-08387b245ecfe5fb736d2d6753b880e644a4f3e2.zip |
tls: remove unused ocsp extension parsing
The OCSP info from parsing the TLS ClientHello has not been used since
550c263, remove it.
See: https://github.com/nodejs/node/pull/1464
PR-URL: https://github.com/nodejs/node/pull/25153
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Diffstat (limited to 'src/node_crypto_clienthello.cc')
-rw-r--r-- | src/node_crypto_clienthello.cc | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/src/node_crypto_clienthello.cc b/src/node_crypto_clienthello.cc index cbe1be3273..b037575577 100644 --- a/src/node_crypto_clienthello.cc +++ b/src/node_crypto_clienthello.cc @@ -112,7 +112,6 @@ void ClientHelloParser::ParseHeader(const uint8_t* data, size_t avail) { hello.session_id_ = session_id_; hello.session_size_ = session_size_; hello.has_ticket_ = tls_ticket_ != nullptr && tls_ticket_size_ != 0; - hello.ocsp_request_ = ocsp_request_; hello.servername_ = servername_; hello.servername_size_ = static_cast<uint8_t>(servername_size_); onhello_cb_(cb_arg_, hello); @@ -149,18 +148,6 @@ void ClientHelloParser::ParseExtension(const uint16_t type, } } break; - case kStatusRequest: - // We are ignoring any data, just indicating the presence of extension - if (len < kMinStatusRequestSize) - return; - - // Unknown type, ignore it - if (data[0] != kStatusRequestOCSP) - break; - - // Ignore extensions, they won't work with caching on backend anyway - ocsp_request_ = 1; - break; case kTLSSessionTicket: tls_ticket_size_ = len; tls_ticket_ = data + len; |