diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-10 01:26:17 +0100 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-13 15:04:43 +0100 |
commit | a2bed79726f4de893eeac15d0b796103d2c65830 (patch) | |
tree | e557d57720e80113936159147dba2385bf9c94e4 /lib/timers.js | |
parent | b21e7c7bcf23a2715951e4cd96180e4dbf1dcd4d (diff) | |
download | android-node-v8-a2bed79726f4de893eeac15d0b796103d2c65830.tar.gz android-node-v8-a2bed79726f4de893eeac15d0b796103d2c65830.tar.bz2 android-node-v8-a2bed79726f4de893eeac15d0b796103d2c65830.zip |
timers: remove dead code and simplify args check
The `setUnrefTimeout` function is never called with more arguments
than two. So quite some code was dead and never used. This removes
that code and simplifies the args check not to coerce objects to
booleans.
PR-URL: https://github.com/nodejs/node/pull/26555
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'lib/timers.js')
-rw-r--r-- | lib/timers.js | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/lib/timers.js b/lib/timers.js index d57b1ceb3e..a81e8bc71e 100644 --- a/lib/timers.js +++ b/lib/timers.js @@ -331,7 +331,7 @@ function listOnTimeout(list, now) { try { const args = timer._timerArgs; - if (!args) + if (args === undefined) timer._onTimeout(); else Reflect.apply(timer._onTimeout, timer, args); @@ -470,8 +470,9 @@ function setTimeout(callback, after, arg1, arg2, arg3) { } setTimeout[internalUtil.promisify.custom] = function(after, value) { + const args = value !== undefined ? [value] : value; return new Promise((resolve) => { - active(new Timeout(resolve, after, [value], false)); + active(new Timeout(resolve, after, args, false)); }); }; |