diff options
| author | Matteo Collina <hello@matteocollina.com> | 2017-08-23 18:29:49 +0200 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2017-08-25 14:28:54 -0700 |
| commit | 4ca8ff264f368c301827e07956f313cebd1b8de8 (patch) | |
| tree | 0b742ba1a120036b62cdbea1eafb2ba42d3d8664 /lib/http2.js | |
| parent | 8987ae843e034745f7247f63928d39f06ed7b116 (diff) | |
| download | android-node-v8-4ca8ff264f368c301827e07956f313cebd1b8de8.tar.gz android-node-v8-4ca8ff264f368c301827e07956f313cebd1b8de8.tar.bz2 android-node-v8-4ca8ff264f368c301827e07956f313cebd1b8de8.zip | |
http2: refactor error handling
This changes the error handling model of ServerHttp2Stream,
ServerHttp2Request and ServerHttp2Response.
An 'error' emitted on ServerHttp2Stream will not go to
'uncaughtException' anymore, but to the server 'streamError'.
On the stream 'error', ServerHttp2Request will emit 'abort', while
ServerHttp2Response would do nothing
See: https://github.com/nodejs/node/issues/14963
PR-URL: https://github.com/nodejs/node/pull/14991
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Diffstat (limited to 'lib/http2.js')
| -rw-r--r-- | lib/http2.js | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/http2.js b/lib/http2.js index ab9e33b2a2..de06de1cc4 100644 --- a/lib/http2.js +++ b/lib/http2.js @@ -15,7 +15,7 @@ const { createSecureServer, connect, Http2ServerRequest, - Http2ServerResponse, + Http2ServerResponse } = require('internal/http2/core'); module.exports = { @@ -27,5 +27,5 @@ module.exports = { createSecureServer, connect, Http2ServerResponse, - Http2ServerRequest, + Http2ServerRequest }; |