diff options
author | Refael Ackermann <refack@gmail.com> | 2019-05-23 18:57:12 -0400 |
---|---|---|
committer | Michaël Zasso <targos@protonmail.com> | 2019-06-04 18:45:56 +0200 |
commit | 0a5ff4cb331fb3e7ff4c53922ee2e2cef6870fe7 (patch) | |
tree | 16564bc7fccf8c0966fcfc450fdab392e53f8f55 /deps/v8 | |
parent | b411114a52d04fdd380094ff6e783dc0020e861f (diff) | |
download | android-node-v8-0a5ff4cb331fb3e7ff4c53922ee2e2cef6870fe7.tar.gz android-node-v8-0a5ff4cb331fb3e7ff4c53922ee2e2cef6870fe7.tar.bz2 android-node-v8-0a5ff4cb331fb3e7ff4c53922ee2e2cef6870fe7.zip |
deps: V8: template explicit instantiation for GCC-8
Fails to link for missing:
void JSObject::ApplyAttributesToDictionary<NumberDictionary>(...)
Backport-PR-URL: https://github.com/nodejs/node/pull/28005
PR-URL: https://github.com/nodejs/node/pull/27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'deps/v8')
-rw-r--r-- | deps/v8/src/elements.cc | 5 | ||||
-rw-r--r-- | deps/v8/src/objects/js-objects.cc | 5 |
2 files changed, 10 insertions, 0 deletions
diff --git a/deps/v8/src/elements.cc b/deps/v8/src/elements.cc index b523cd7dde..5262cb7a60 100644 --- a/deps/v8/src/elements.cc +++ b/deps/v8/src/elements.cc @@ -62,6 +62,11 @@ namespace v8 { namespace internal { +// Explicit instantiation declarations. +extern template void JSObject::ApplyAttributesToDictionary( + Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary, + const PropertyAttributes attributes); + namespace { diff --git a/deps/v8/src/objects/js-objects.cc b/deps/v8/src/objects/js-objects.cc index 841eec0edf..5191f237f6 100644 --- a/deps/v8/src/objects/js-objects.cc +++ b/deps/v8/src/objects/js-objects.cc @@ -5836,5 +5836,10 @@ Handle<String> JSMessageObject::GetSourceLine() const { return isolate->factory()->NewSubString(src, info.line_start, info.line_end); } +// Explicit instantiation definitions. +template void JSObject::ApplyAttributesToDictionary( + Isolate* isolate, ReadOnlyRoots roots, Handle<NumberDictionary> dictionary, + const PropertyAttributes attributes); + } // namespace internal } // namespace v8 |