diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2019-06-07 11:36:39 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-06-18 16:03:14 +0200 |
| commit | eb89c06b95aaed8e928c89383752f6d72bc153d9 (patch) | |
| tree | 0e58ff844832653580d3ea3fb08a43ede996f593 /configure.py | |
| parent | 02fdf5c14caa1eb60399346264bb996714e64e27 (diff) | |
| download | android-node-v8-eb89c06b95aaed8e928c89383752f6d72bc153d9.tar.gz android-node-v8-eb89c06b95aaed8e928c89383752f6d72bc153d9.tar.bz2 android-node-v8-eb89c06b95aaed8e928c89383752f6d72bc153d9.zip | |
build: fix icu-i18n pkg-config version check
The pkg_config() helper can either return a tuple of None values
(no pkg-config installed) and that was what the check was testing
for, but it can also return a tuple of empty strings when the
package isn't installed.
PR-URL: https://github.com/nodejs/node/pull/28118
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Refael Ackermann (רפאל פלחי) <refack@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'configure.py')
| -rwxr-xr-x | configure.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/configure.py b/configure.py index 71943cae2c..9d9f0aec0b 100755 --- a/configure.py +++ b/configure.py @@ -1348,7 +1348,7 @@ def configure_intl(o): # ICU from pkg-config. o['variables']['v8_enable_i18n_support'] = 1 pkgicu = pkg_config('icu-i18n') - if pkgicu[0] is None: + if not pkgicu[0]: error('''Could not load pkg-config data for "icu-i18n". See above errors or the README.md.''') (libs, cflags, libpath, icuversion) = pkgicu |