diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-08-09 12:22:07 +0200 |
|---|---|---|
| committer | Jon Moss <me@jonathanmoss.me> | 2018-08-11 20:30:23 -0400 |
| commit | ec8f31dacead7cabf334132f289961caea7033ec (patch) | |
| tree | 5c3d8e8daf560e6a723e59f7133d048b82d36514 /Makefile | |
| parent | 30b5b8485bdeddccf71ef5078b1cc181f697308b (diff) | |
| download | android-node-v8-ec8f31dacead7cabf334132f289961caea7033ec.tar.gz android-node-v8-ec8f31dacead7cabf334132f289961caea7033ec.tar.bz2 android-node-v8-ec8f31dacead7cabf334132f289961caea7033ec.zip | |
build: add CONFIG_FLAGS to with-code-cache target
This commit adds CONFIG_FLAGS to allow the with-code-cache target to be
used with a debug build. The motivation for this is to make it easier to
debug a build with the code cache enabled.
The suggested usage:
$ make BUILDTYPE=Debug with-code-cache
The BUILDTYPE option is not needed if ./configure was already
configured with --debug.
PR-URL: https://github.com/nodejs/node/pull/22207
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 8 |
1 files changed, 6 insertions, 2 deletions
@@ -94,13 +94,17 @@ $(NODE_G_EXE): config.gypi out/Makefile CODE_CACHE_DIR ?= out/$(BUILDTYPE)/obj/gen CODE_CACHE_FILE ?= $(CODE_CACHE_DIR)/node_code_cache.cc +ifeq ($(BUILDTYPE),Debug) +CONFIG_FLAGS += --debug +endif .PHONY: with-code-cache with-code-cache: - $(PYTHON) ./configure + @echo $(CONFIG_FLAGS) + $(PYTHON) ./configure $(CONFIG_FLAGS) $(MAKE) mkdir -p $(CODE_CACHE_DIR) out/$(BUILDTYPE)/$(NODE_EXE) --expose-internals tools/generate_code_cache.js $(CODE_CACHE_FILE) - $(PYTHON) ./configure --code-cache-path $(CODE_CACHE_FILE) + $(PYTHON) ./configure --code-cache-path $(CODE_CACHE_FILE) $(CONFIG_FLAGS) $(MAKE) .PHONY: test-code-cache |