diff options
| author | Benjamin Coe <ben@npmjs.com> | 2018-05-31 17:33:21 -0700 |
|---|---|---|
| committer | Benjamin Coe <ben@npmjs.com> | 2018-06-25 16:28:27 -0700 |
| commit | ba4f5e9bb9a2b80f3760b44b7962a77adda50afd (patch) | |
| tree | 6681f1a06a781ea22b50e59b144722c4d06b308a /Makefile | |
| parent | 198c872990276b0e6aab82cefa39fffdbd86b733 (diff) | |
| download | android-node-v8-ba4f5e9bb9a2b80f3760b44b7962a77adda50afd.tar.gz android-node-v8-ba4f5e9bb9a2b80f3760b44b7962a77adda50afd.tar.bz2 android-node-v8-ba4f5e9bb9a2b80f3760b44b7962a77adda50afd.zip | |
build: fail on instrumentation errors
nyc was silently failing to instrument new language features,
resulting in a failure to instrument console.js.
Refs: https://github.com/nodejs/node/issues/20952
PR-URL: https://github.com/nodejs/node/pull/21071
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Rebecca Turner <me@re-becca.org>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -175,7 +175,8 @@ coverage-build: all "$(CURDIR)/build/jenkins/scripts/coverage/gcovr-patches-3.4.diff"); fi if [ -d lib_ ]; then $(RM) -r lib; mv lib_ lib; fi mv lib lib_ - $(NODE) ./node_modules/.bin/nyc instrument --extension .js --extension .mjs lib_/ lib/ + NODE_DEBUG=nyc $(NODE) ./node_modules/.bin/nyc instrument --extension .js \ + --extension .mjs --exit-on-error lib_/ lib/ $(MAKE) .PHONY: coverage-test |