diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-11-15 16:47:44 -0800 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-11-17 18:49:22 -0800 |
| commit | 282c5cfc27532c750654be7154c3df11a7347416 (patch) | |
| tree | 73bf8004339d1f969215ab6b01041450abbd6d26 /COLLABORATOR_GUIDE.md | |
| parent | efa5bf9cf6ba60ec705c33ee95a5d24ae5c786ca (diff) | |
| download | android-node-v8-282c5cfc27532c750654be7154c3df11a7347416.tar.gz android-node-v8-282c5cfc27532c750654be7154c3df11a7347416.tar.bz2 android-node-v8-282c5cfc27532c750654be7154c3df11a7347416.zip | |
doc: simplify first-time contributors section of Collaborator Guide
PR-URL: https://github.com/nodejs/node/pull/24387
Reviewed-By: Ouyang Yadong <oyydoibh@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Diffstat (limited to 'COLLABORATOR_GUIDE.md')
| -rw-r--r-- | COLLABORATOR_GUIDE.md | 14 |
1 files changed, 6 insertions, 8 deletions
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index deadf87ed1..1eb75fc1f8 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -50,16 +50,14 @@ request. See [Who to CC in the issue tracker](#who-to-cc-in-the-issue-tracker). ### Welcoming First-Time Contributors -Courtesy should always be shown to individuals submitting issues and pull -requests to the Node.js project. Be welcoming to first-time contributors, -identified by the GitHub  -badge. +Always show courtesy to individuals submitting issues and pull requests. Be +welcoming to first-time contributors, identified by the GitHub + badge. -For first-time contributors, check if the commit author is the same as the -pull request author, and ask if they have configured their git +For first-time contributors, check if the commit author is the same as the pull +request author. This way, once their pull request lands, GitHub will show them +as a _Contributor_. Ask if they have configured their git [username][git-username] and [email][git-email] to their liking. -This is to make sure they would be promoted to "contributor" once their -pull request lands. ### Closing Issues and Pull Requests |