1 files changed, 88 insertions, 31 deletions

diff --git a/packages/merchant-backoffice-ui/src/paths/instance/accounts/update/index.tsx b/packages/merchant-backoffice-ui/src/paths/instance/accounts/update/index.tsx
index 44dee7651..70942fd55 100644
--- a/packages/merchant-backoffice-ui/src/paths/instance/accounts/update/index.tsx
+++ b/packages/merchant-backoffice-ui/src/paths/instance/accounts/update/index.tsx
@@ -1,6 +1,6 @@
 /*
  This file is part of GNU Taler
- (C) 2021-2023 Taler Systems S.A.
+ (C) 2021-2024 Taler Systems S.A.
 
  GNU Taler is free software; you can redistribute it and/or modify it under the
  terms of the GNU General Public License as published by the Free Software
@@ -19,68 +19,125 @@
  * @author Sebastian Javier Marchano (sebasjm)
  */
 
-import { HttpStatusCode } from "@gnu-taler/taler-util";
+import { HttpStatusCode, TalerError, TalerMerchantApi, assertUnreachable } from "@gnu-taler/taler-util";
 import {
-  ErrorType,
-  HttpError,
-  useTranslationContext,
+  useTranslationContext
 } from "@gnu-taler/web-util/browser";
 import { Fragment, VNode, h } from "preact";
 import { useState } from "preact/hooks";
+import { ErrorLoadingMerchant } from "../../../../components/ErrorLoadingMerchant.js";
 import { Loading } from "../../../../components/exception/loading.js";
 import { NotificationCard } from "../../../../components/menu/index.js";
-import { MerchantBackend, WithId } from "../../../../declaration.js";
-import { useBankAccountAPI, useBankAccountDetails } from "../../../../hooks/bank.js";
+import { useSessionContext } from "../../../../context/session.js";
+import { useBankAccountDetails } from "../../../../hooks/bank.js";
 import { Notification } from "../../../../utils/types.js";
+import { LoginPage } from "../../../login/index.js";
+import { NotFoundPageOrAdminCreate } from "../../../notfound/index.js";
+import { TestRevenueErrorType, testRevenueAPI } from "../create/index.js";
 import { UpdatePage } from "./UpdatePage.js";
 
-export type Entity = MerchantBackend.BankAccounts.AccountPatchDetails & WithId;
+export type Entity = TalerMerchantApi.AccountPatchDetails & WithId;
 
 interface Props {
   onBack?: () => void;
   onConfirm: () => void;
-  onUnauthorized: () => VNode;
-  onNotFound: () => VNode;
-  onLoadError: (e: HttpError<MerchantBackend.ErrorDetail>) => VNode;
   bid: string;
 }
 export default function UpdateValidator({
   bid,
   onConfirm,
   onBack,
-  onUnauthorized,
-  onNotFound,
-  onLoadError,
 }: Props): VNode {
-  const { updateBankAccount } = useBankAccountAPI();
+  const { lib: api } = useSessionContext();
+  const { state } = useSessionContext();
   const result = useBankAccountDetails(bid);
   const [notif, setNotif] = useState<Notification | undefined>(undefined);
 
   const { i18n } = useTranslationContext();
 
-  if (result.loading) return <Loading />;
-  if (!result.ok) {
-    if (
-      result.type === ErrorType.CLIENT &&
-      result.status === HttpStatusCode.Unauthorized
-    )
-      return onUnauthorized();
-    if (
-      result.type === ErrorType.CLIENT &&
-      result.status === HttpStatusCode.NotFound
-    )
-      return onNotFound();
-    return onLoadError(result);
+  if (!result) return <Loading />;
+  if (result instanceof TalerError) {
+    return <ErrorLoadingMerchant error={result} />;
+  }
+  if (result.type === "fail") {
+    switch (result.case) {
+      case HttpStatusCode.NotFound: {
+        return <NotFoundPageOrAdminCreate />;
+      }
+      case HttpStatusCode.Unauthorized: {
+        return <LoginPage />
+      }
+      default: {
+        assertUnreachable(result);
+      }
+    }
   }
 
   return (
     <Fragment>
       <NotificationCard notification={notif} />
       <UpdatePage
-        account={{ ...result.data, id: bid }}
+        account={{ ...result.body, id: bid }}
         onBack={onBack}
-        onUpdate={(data) => {
-          return updateBankAccount(bid, data)
+        onUpdate={async (request) => {
+          const revenueAPI = !request.credit_facade_url
+            ? undefined
+            : new URL("./", request.credit_facade_url);
+
+          if (revenueAPI) {
+            const resp = await testRevenueAPI(
+              revenueAPI,
+              request.credit_facade_credentials,
+            );
+            if (resp.type === "fail") {
+              switch (resp.case) {
+                case TestRevenueErrorType.NO_CONFIG: {
+                  setNotif({
+                    message: i18n.str`Could not create account`,
+                    type: "ERROR",
+                    description: i18n.str`The endpoint doesn't seems to be a Taler Revenue API`,
+                  });
+                  return;
+                }
+                case TestRevenueErrorType.CLIENT_BAD_REQUEST: {
+                  setNotif({
+                    message: i18n.str`Could not create account`,
+                    type: "ERROR",
+                    description: i18n.str`Server replied with "bad request".`,
+                  });
+                  return;
+                }
+                case TestRevenueErrorType.UNAUTHORIZED: {
+                  setNotif({
+                    message: i18n.str`Could not create account`,
+                    type: "ERROR",
+                    description: i18n.str`Unauthorized, try with another credentials.`,
+                  });
+                  return;
+                }
+                case TestRevenueErrorType.NOT_FOUND: {
+                  setNotif({
+                    message: i18n.str`Could not create account`,
+                    type: "ERROR",
+                    description: i18n.str`Check facade URL, server replied with "not found".`,
+                  });
+                  return;
+                }
+                case TestRevenueErrorType.GENERIC_ERROR: {
+                  setNotif({
+                    message: i18n.str`Could not create account`,
+                    type: "ERROR",
+                    description: resp.detail.hint,
+                  });
+                  return;
+                }
+                default: {
+                  assertUnreachable(resp.case)
+                }
+              }
+            }
+          }
+          return api.instance.updateBankAccount(state.token, bid, request)
             .then(onConfirm)
             .catch((error) => {
               setNotif({