taler-typescript-core

commit f9d4ff5b43e48a07ac81d7e7ef800ddb12f5f90a
parent 366b2e6d8bdaab0995ce43e8f56edb3600ab7c01
Author: Sebastian <sebasjm@gmail.com>
Date:   Wed, 12 Jun 2024 12:38:28 -0300

do not throw error when asking withdrawal info for instructed amount 0

Diffstat:
M
packages/taler-wallet-core/src/pay-peer-pull-credit.ts
 | 
10
++++++++++
M
packages/taler-wallet-core/src/pay-peer-push-credit.ts
 | 
6
++++++
M
packages/taler-wallet-core/src/withdraw.ts
 | 
8
--------

3 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/packages/taler-wallet-core/src/pay-peer-pull-credit.ts b/packages/taler-wallet-core/src/pay-peer-pull-credit.ts
@@ -934,6 +934,11 @@ export async function checkPeerPullPaymentInitiation(
     Amounts.parseOrThrow(req.amount),
     undefined,
   );
+  if (wi.selectedDenoms.selectedDenoms.length === 0) {
+    throw Error(
+      `unable to check pull payment from ${exchangeUrl}, can't select denominations for instructed amount (${req.amount}`,
+    );
+  }
 
   logger.trace(`got withdrawal info`);
 
@@ -1054,6 +1059,11 @@ export async function initiatePeerPullPayment(
     Amounts.parseOrThrow(req.partialContractTerms.amount),
     undefined,
   );
+  if (wi.selectedDenoms.selectedDenoms.length === 0) {
+    throw Error(
+      `unable to initiate pull payment from ${exchangeBaseUrl}, can't select denominations for instructed amount (${req.partialContractTerms.amount}`,
+    );
+  }
 
   const mergeTimestamp = TalerPreciseTimestamp.now();
 
diff --git a/packages/taler-wallet-core/src/pay-peer-push-credit.ts b/packages/taler-wallet-core/src/pay-peer-push-credit.ts
@@ -461,6 +461,12 @@ export async function preparePeerPushCredit(
     undefined,
   );
 
+  if (wi.selectedDenoms.selectedDenoms.length === 0) {
+    throw Error(
+      `unable to prepare push credit from ${exchangeBaseUrl}, can't select denominations for instructed amount (${purseStatus.balance}`,
+    );
+  }
+
   const transitionInfo = await wex.db.runReadWriteTx(
     { storeNames: ["contractTerms", "peerPushCredit"] },
     async (tx) => {
diff --git a/packages/taler-wallet-core/src/withdraw.ts b/packages/taler-wallet-core/src/withdraw.ts
@@ -2267,14 +2267,6 @@ export async function getExchangeWithdrawalInfo(
 
   logger.trace("selection done");
 
-  if (selectedDenoms.selectedDenoms.length === 0) {
-    throw Error(
-      `unable to withdraw from ${exchangeBaseUrl}, can't select denominations for instructed amount (${Amounts.stringify(
-        instructedAmount,
-      )}`,
-    );
-  }
-
   const exchangeWireAccounts: string[] = [];
 
   for (const account of exchange.wireInfo.accounts) {