taler-typescript-core

commit f9d3018668eb801b4598592b1a01e4f3efc2f061
parent 7b2de89444f27faa554bb40855da996a113ef5b9
Author: Sebastian <sebasjm@gmail.com>
Date:   Thu, 13 Apr 2023 12:57:23 -0300

firefox support

Diffstat:
M
packages/taler-wallet-webextension/manifest-v2.json
 | 
4
++++
M
packages/taler-wallet-webextension/src/taler-wallet-interaction-support.ts
 | 
6
++++++

2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/packages/taler-wallet-webextension/manifest-v2.json b/packages/taler-wallet-webextension/manifest-v2.json
@@ -21,6 +21,10 @@
     "https://*/*",
     "activeTab"
   ],
+  "web_accessible_resources": [
+    "static/wallet.html",
+    "dist/taler-wallet-interaction-support.js"
+  ],
   "optional_permissions": [
     "http://*/*",
     "https://*/*",
diff --git a/packages/taler-wallet-webextension/src/taler-wallet-interaction-support.ts b/packages/taler-wallet-webextension/src/taler-wallet-interaction-support.ts
@@ -98,10 +98,16 @@ function buildApi(config: Readonly<Info>): API {
       logger.debug(`onclick: could not convert "${hrefAttr.value}" into path`);
       return;
     }
+    // we can use window.open, but maybe some browser will block it?
     window.open(page, windowTarget);
     ev.preventDefault();
     ev.stopPropagation();
     ev.stopImmediatePropagation();
+    // another possibility is to change the location when the click is made
+    // or when the anchor is found
+    // hrefAttr.value = page
+    // TODO: explore different possibilities and maybe allow the configuration
+    // using the meta-tag
     return false;
   }