taler-typescript-core

commit f64720a68f5692c4616958ddcf623805fdf51a43
parent d229818619a4b29d5be2c10ebea2adc64a09d243
Author: Florian Dold <florian@dold.me>
Date:   Tue, 20 May 2025 15:27:20 +0200

wallet-core: fix kycUrl in peer-pull-credit (#9969)

Also improve the test

Diffstat:
M
packages/taler-harness/src/integrationtests/test-kyc-peer-pull.ts
 | 
4
++++
M
packages/taler-wallet-core/src/pay-peer-pull-credit.ts
 | 
12
++++++------

2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/packages/taler-harness/src/integrationtests/test-kyc-peer-pull.ts b/packages/taler-harness/src/integrationtests/test-kyc-peer-pull.ts
@@ -105,6 +105,10 @@ export async function runKycPeerPullTest(t: GlobalTestState) {
 
   t.assertTrue(!!kycPaytoHash);
 
+  t.assertTrue(!!txDet.kycUrl);
+  t.assertTrue(!!txDet.kycAccessToken);
+  t.assertTrue(txDet.kycUrl.includes(txDet.kycAccessToken));
+
   await postAmlDecisionNoRules(t, {
     amlPriv: amlKeypair.priv,
     amlPub: amlKeypair.pub,
diff --git a/packages/taler-wallet-core/src/pay-peer-pull-credit.ts b/packages/taler-wallet-core/src/pay-peer-pull-credit.ts
@@ -85,20 +85,20 @@ import {
 } from "./exchanges.js";
 import { checkPeerCreditHardLimitExceeded } from "./kyc.js";
 import {
+  getMergeReserveInfo,
   isPurseDeposited,
   recordCreate,
-  getMergeReserveInfo,
-  recordTransitionStatus,
+  recordDelete,
   recordTransition,
+  recordTransitionStatus,
   recordUpdateMeta,
-  recordDelete,
   waitForKycCompletion,
 } from "./pay-peer-common.js";
 import {
   constructTransactionIdentifier,
   isUnsuccessfulTransaction,
 } from "./transactions.js";
-import { walletExchangeClient, WalletExecutionContext } from "./wallet.js";
+import { WalletExecutionContext, walletExchangeClient } from "./wallet.js";
 import {
   WithdrawTransactionContext,
   getExchangeWithdrawalInfo,
@@ -196,9 +196,9 @@ export class PeerPullCreditTransactionContext implements TransactionContext {
     let pullCreditOrt = await tx.operationRetries.get(pullCreditOpId);
 
     let kycUrl: string | undefined = undefined;
-    if (pullCredit.kycPaytoHash) {
+    if (pullCredit.kycAccessToken) {
       kycUrl = new URL(
-        `kyc-spa/${pullCredit.kycPaytoHash}`,
+        `kyc-spa/${pullCredit.kycAccessToken}`,
         pullCredit.exchangeBaseUrl,
       ).href;
     }