taler-typescript-core

commit e700111ac1d156834478d480d05bc6e651f48bcf
parent 17ca6918ed01006a296f99f03f6bc3db39398a87
Author: Florian Dold <florian@dold.me>
Date:   Tue, 30 Jul 2024 20:47:02 +0200

wallet-core: remove unused getWithdrawalTransactionByUri request

Diffstat:
M
packages/taler-util/src/types-taler-wallet-transactions.ts
 | 
10
----------
M
packages/taler-wallet-core/src/transactions.ts
 | 
26
--------------------------
M
packages/taler-wallet-core/src/wallet-api-types.ts
 | 
10
----------
M
packages/taler-wallet-core/src/wallet.ts
 | 
5
-----

4 files changed, 0 insertions(+), 51 deletions(-)
diff --git a/packages/taler-util/src/types-taler-wallet-transactions.ts b/packages/taler-util/src/types-taler-wallet-transactions.ts
@@ -740,16 +740,6 @@ export const codecForTransactionByIdRequest =
       .property("transactionId", codecForString())
       .build("TransactionByIdRequest");
 
-export interface WithdrawalTransactionByURIRequest {
-  talerWithdrawUri: string;
-}
-
-export const codecForWithdrawalTransactionByURIRequest =
-  (): Codec<WithdrawalTransactionByURIRequest> =>
-    buildCodecForObject<WithdrawalTransactionByURIRequest>()
-      .property("talerWithdrawUri", codecForString())
-      .build("WithdrawalTransactionByURIRequest");
-
 export const codecForTransactionsRequest = (): Codec<TransactionsRequest> =>
   buildCodecForObject<TransactionsRequest>()
     .property("currency", codecOptional(codecForString()))
diff --git a/packages/taler-wallet-core/src/transactions.ts b/packages/taler-wallet-core/src/transactions.ts
@@ -35,8 +35,6 @@ import {
   TransactionsResponse,
   TransactionState,
   TransactionType,
-  TransactionWithdrawal,
-  WithdrawalTransactionByURIRequest,
 } from "@gnu-taler/taler-util";
 import {
   constructTaskIdentifier,
@@ -197,30 +195,6 @@ export function isUnsuccessfulTransaction(state: TransactionState): boolean {
   );
 }
 
-export async function getWithdrawalTransactionByUri(
-  wex: WalletExecutionContext,
-  request: WithdrawalTransactionByURIRequest,
-): Promise<TransactionWithdrawal | undefined> {
-  return await wex.db.runAllStoresReadOnlyTx({}, async (tx) => {
-    const withdrawalGroupRecord =
-      await tx.withdrawalGroups.indexes.byTalerWithdrawUri.get(
-        request.talerWithdrawUri,
-      );
-    if (!withdrawalGroupRecord) {
-      return undefined;
-    }
-    const ctx = new WithdrawTransactionContext(
-      wex,
-      withdrawalGroupRecord.withdrawalGroupId,
-    );
-    const dbTxn = await ctx.lookupFullTransaction(tx);
-    if (!dbTxn || dbTxn.type !== TransactionType.Withdrawal) {
-      return undefined;
-    }
-    return dbTxn;
-  });
-}
-
 /**
  * Retrieve the full event history for this wallet.
  */
diff --git a/packages/taler-wallet-core/src/wallet-api-types.ts b/packages/taler-wallet-core/src/wallet-api-types.ts
@@ -140,7 +140,6 @@ import {
   TestingWaitTransactionRequest,
   Transaction,
   TransactionByIdRequest,
-  TransactionWithdrawal,
   TransactionsRequest,
   TransactionsResponse,
   TxIdResponse,
@@ -156,7 +155,6 @@ import {
   WithdrawTestBalanceRequest,
   WithdrawUriInfoResponse,
   WithdrawalDetailsForAmount,
-  WithdrawalTransactionByURIRequest,
 } from "@gnu-taler/taler-util";
 import {
   AddBackupProviderRequest,
@@ -184,7 +182,6 @@ export enum WalletApiOperation {
   AddExchange = "addExchange",
   GetTransactions = "getTransactions",
   GetTransactionById = "getTransactionById",
-  GetWithdrawalTransactionByUri = "getWithdrawalTransactionByUri",
   TestingGetSampleTransactions = "testingGetSampleTransactions",
   ListExchanges = "listExchanges",
   GetExchangeEntryByUrl = "getExchangeEntryByUrl",
@@ -410,12 +407,6 @@ export type GetTransactionByIdOp = {
   response: Transaction;
 };
 
-export type GetWithdrawalTransactionByUriOp = {
-  op: WalletApiOperation.GetWithdrawalTransactionByUri;
-  request: WithdrawalTransactionByURIRequest;
-  response: TransactionWithdrawal | undefined;
-};
-
 export type RetryPendingNowOp = {
   op: WalletApiOperation.RetryPendingNow;
   request: EmptyObject;
@@ -1277,7 +1268,6 @@ export type WalletOperations = {
   [WalletApiOperation.GetTransactions]: GetTransactionsOp;
   [WalletApiOperation.TestingGetSampleTransactions]: TestingGetSampleTransactionsOp;
   [WalletApiOperation.GetTransactionById]: GetTransactionByIdOp;
-  [WalletApiOperation.GetWithdrawalTransactionByUri]: GetWithdrawalTransactionByUriOp;
   [WalletApiOperation.RetryPendingNow]: RetryPendingNowOp;
   [WalletApiOperation.GetActiveTasks]: GetActiveTasksOp;
   [WalletApiOperation.GetUserAttentionRequests]: GetUserAttentionRequests;
diff --git a/packages/taler-wallet-core/src/wallet.ts b/packages/taler-wallet-core/src/wallet.ts
@@ -335,7 +335,6 @@ import {
   failTransaction,
   getTransactionById,
   getTransactions,
-  getWithdrawalTransactionByUri,
   parseTransactionIdentifier,
   restartAll as restartAllRunningTasks,
   resumeTransaction,
@@ -1526,10 +1525,6 @@ const handlers: { [T in WalletApiOperation]: HandlerWithValidator<T> } = {
     codec: codecForTransactionByIdRequest(),
     handler: getTransactionById,
   },
-  [WalletApiOperation.GetWithdrawalTransactionByUri]: {
-    codec: codecForGetWithdrawalDetailsForUri(),
-    handler: getWithdrawalTransactionByUri,
-  },
   [WalletApiOperation.AddExchange]: {
     codec: codecForAddExchangeRequest(),
     handler: handleAddExchange,