taler-typescript-core

commit dde3654377eb6c1620eac19ff348e2b5f4e14b1e
parent 303c02c419e08a8ce5f43bed0693946b6f3e7275
Author: Florian Dold <florian@dold.me>
Date:   Wed, 16 Apr 2025 16:37:11 +0200

-comments

Diffstat:
M
packages/taler-util/src/types-taler-wallet.ts
 | 
4
++--
M
packages/taler-wallet-core/src/withdraw.ts
 | 
4
++++

2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/packages/taler-util/src/types-taler-wallet.ts b/packages/taler-util/src/types-taler-wallet.ts
@@ -1223,7 +1223,7 @@ export interface WalletBankAccountInfo {
 
   /**
    * Did we previously complete a KYC process for this bank account?
-   * 
+   *
    * @deprecated no enough information since the kyc can be completed for one exchange but not for another
    * https://bugs.gnunet.org/view.php?id=9696
    */
@@ -2515,7 +2515,7 @@ export interface CreateDepositGroupRequest {
   depositPaytoUri: string;
 
   /**
-   * Amount to deposit.
+   * Amount to deposit (effective amount).
    */
   amount: AmountString;
 
diff --git a/packages/taler-wallet-core/src/withdraw.ts b/packages/taler-wallet-core/src/withdraw.ts
@@ -2421,6 +2421,10 @@ async function processWithdrawalGroupPendingReady(
     "expected withdrawal group to have effective amount",
   );
 
+  // We check for the balance KYC only after the money has arrived for multiple reasons:
+  // (1) The amount might differ (user error or wire fees)
+  // (2) We don't want the to have to do KYC at different times
+
   const kycCheckRes = await checkIncomingAmountLegalUnderKycBalanceThreshold(
     wex,
     withdrawalGroup.exchangeBaseUrl,