taler-typescript-core

commit 1589fcabfe68a42f6ec8517cce67eeb8cbc88b38
parent db8877a68832c93f706802bbf75929190d95ebe0
Author: Florian Dold <dold@taler.net>
Date:   Mon, 24 Aug 2026 02:30:17 +0200

bank web UI: preserve zero-valued admin metrics

Diffstat:
M
packages/libeufin-bank-webui/src/pages/admin/AdminHome.tsx
 | 
23
+++++++++++++++++------

1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/packages/libeufin-bank-webui/src/pages/admin/AdminHome.tsx b/packages/libeufin-bank-webui/src/pages/admin/AdminHome.tsx
@@ -736,15 +736,26 @@ function MetricValueNumber({
 }): VNode {
   const { i18n } = useTranslationContext();
 
-  const cmp = current && previous ? (current < previous ? -1 : 1) : 0;
+  const cmp =
+    current !== undefined && previous !== undefined
+      ? current === previous
+        ? 0
+        : current < previous
+          ? -1
+          : 1
+      : 0;
 
   const rate =
-    !current || Number.isNaN(current) || !previous || Number.isNaN(previous)
+    current === undefined ||
+    Number.isNaN(current) ||
+    previous === undefined ||
+    Number.isNaN(previous) ||
+    previous === 0
       ? 0
       : cmp === -1
-        ? 1 - Math.round(current) / Math.round(previous)
+        ? 1 - current / previous
         : cmp === 1
-          ? Math.round(current) / Math.round(previous) - 1
+          ? current / previous - 1
           : 0;
 
   const negative = cmp === 0 ? undefined : cmp === -1;
@@ -753,13 +764,13 @@ function MetricValueNumber({
     <Fragment>
       <dd class="mt-1 block ">
         <div class="flex justify-start text-2xl items-baseline font-semibold text-indigo-600">
-          {!current ? "-" : current}
+          {current === undefined ? "-" : current}
         </div>
         <div class="flex flex-col">
           <div class="flex justify-end items-baseline text-2xl font-semibold text-indigo-600">
             <small class="ml-2 text-sm font-medium text-gray-500">
               <i18n.Translate>previous</i18n.Translate>{" "}
-              {!previous ? "-" : previous}
+              {previous === undefined ? "-" : previous}
             </small>
           </div>
           {!!rate && (