commit 8cc4f99aa7e7ec15aedbe01a42d266f1c3c68347
parent b37fc8e0156966b0a4c5b4a4f2fcfcad7d7d9dde
Author: Kasper Isager Dalsgarð <kasperisager@hey.com>
Date: Wed, 17 Jul 2024 13:58:08 +0200
Fix `JS_HasException()` when `null` is thrown (#313)
Use `JS_UNINITIALIZED` instead of `JS_NULL` when no exception is pending, so `null` can be thrown and distinguished from no exception pending.
Diffstat:
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/quickjs/quickjs.c b/quickjs/quickjs.c
@@ -1685,7 +1685,7 @@ JSRuntime *JS_NewRuntime2(const JSMallocFunctions *mf, void *opaque)
rt->stack_size = JS_DEFAULT_STACK_SIZE;
JS_UpdateStackTop(rt);
- rt->current_exception = JS_NULL;
+ rt->current_exception = JS_UNINITIALIZED;
return rt;
fail:
@@ -6402,13 +6402,13 @@ JSValue JS_GetException(JSContext *ctx)
JSValue val;
JSRuntime *rt = ctx->rt;
val = rt->current_exception;
- rt->current_exception = JS_NULL;
+ rt->current_exception = JS_UNINITIALIZED;
return val;
}
JS_BOOL JS_HasException(JSContext *ctx)
{
- return !JS_IsNull(ctx->rt->current_exception);
+ return !JS_IsUninitialized(ctx->rt->current_exception);
}
static void dbuf_put_leb128(DynBuf *s, uint32_t v)
@@ -15336,7 +15336,7 @@ static int JS_IteratorClose(JSContext *ctx, JSValueConst enum_obj,
if (is_exception_pending) {
ex_obj = ctx->rt->current_exception;
- ctx->rt->current_exception = JS_NULL;
+ ctx->rt->current_exception = JS_UNINITIALIZED;
res = -1;
} else {
ex_obj = JS_UNDEFINED;
@@ -18689,7 +18689,7 @@ static JSValue __JS_CallInternal(JSContext *caller_ctx, JSValueConst func_obj,
JS_IteratorClose(ctx, sp[-1], TRUE);
} else {
*sp++ = rt->current_exception;
- rt->current_exception = JS_NULL;
+ rt->current_exception = JS_UNINITIALIZED;
pc = b->byte_code_buf + pos;
goto restart;
}