paivana

commit 26a4029e13d47be1182bf2af4259dd02d5689778
parent eaa6a6cecc9697c9ccae283a926ad7c19ab7f426
Author: Christian Grothoff <christian@grothoff.org>
Date:   Mon,  3 Aug 2026 21:42:51 +0200

properly return error codes if configuration/options are bad

Diffstat:
M
src/backend/paivana-httpd.c
 | 
9
+++++++++
M
src/backend/paivana-httpd_daemon.c
 | 
1
+

2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/src/backend/paivana-httpd.c b/src/backend/paivana-httpd.c
@@ -151,6 +151,7 @@ run (void *cls,
         TALER_TEMPLATING_init (PAIVANA_project_data ()))
     {
       GNUNET_break (0);
+      PH_global_ret = EXIT_FAILURE;
       GNUNET_SCHEDULER_shutdown ();
       return;
     }
@@ -158,6 +159,7 @@ run (void *cls,
   if (! PAIVANA_HTTPD_reverse_init ())
   {
     GNUNET_break (0);
+    PH_global_ret = EXIT_FAILURE;
     GNUNET_SCHEDULER_shutdown ();
     return;
   }
@@ -174,6 +176,7 @@ run (void *cls,
     GNUNET_log_config_missing (GNUNET_ERROR_TYPE_ERROR,
                                "paivana",
                                "DESTINATION_BASE_URL");
+    PH_global_ret = EXIT_NOTCONFIGURED;
     GNUNET_SCHEDULER_shutdown ();
     return;
   }
@@ -183,6 +186,7 @@ run (void *cls,
                                "paivana",
                                "DESTINATION_BASE_URL",
                                "not a web url");
+    PH_global_ret = EXIT_NOTCONFIGURED;
     GNUNET_SCHEDULER_shutdown ();
     return;
   }
@@ -210,6 +214,7 @@ run (void *cls,
       GNUNET_log_config_missing (GNUNET_ERROR_TYPE_ERROR,
                                  "paivana",
                                  "MERCHANT_BACKEND_URL");
+      PH_global_ret = EXIT_NOTCONFIGURED;
       GNUNET_SCHEDULER_shutdown ();
       return;
     }
@@ -219,6 +224,7 @@ run (void *cls,
                                  "paivana",
                                  "MERCHANT_BACKEND_URL",
                                  "not a web url");
+      PH_global_ret = EXIT_NOTCONFIGURED;
       GNUNET_SCHEDULER_shutdown ();
       return;
     }
@@ -262,6 +268,7 @@ run (void *cls,
                                    "WHITELIST",
                                    "Invalid regular expression");
         GNUNET_free (whitelist);
+        PH_global_ret = EXIT_NOTCONFIGURED;
         GNUNET_SCHEDULER_shutdown ();
         return;
       }
@@ -289,6 +296,7 @@ run (void *cls,
                                  "paivana",
                                  "BASE_URL",
                                  "not a web url");
+      PH_global_ret = EXIT_NOTCONFIGURED;
       GNUNET_SCHEDULER_shutdown ();
       return;
     }
@@ -336,6 +344,7 @@ run (void *cls,
       GNUNET_log_config_missing (GNUNET_ERROR_TYPE_ERROR,
                                  "paivana",
                                  "MERCHANT_ACCESS_TOKEN");
+      PH_global_ret = EXIT_NOTCONFIGURED;
       GNUNET_SCHEDULER_shutdown ();
       return;
     }
diff --git a/src/backend/paivana-httpd_daemon.c b/src/backend/paivana-httpd_daemon.c
@@ -350,6 +350,7 @@ start_daemon (void *cls,
   if (NULL == mhd)
   {
     GNUNET_break (0);
+    PH_global_ret = EXIT_FAILURE;
     GNUNET_SCHEDULER_shutdown ();
     return;
   }