merchant

commit f5391593fe745204470166f27c0f2d89de0a765c
parent 14d045a49f53396f254f4935d0bf33e9eb4e6fdc
Author: Christian Grothoff <christian@grothoff.org>
Date:   Sat, 10 May 2025 01:27:12 +0200

-fix another leak and error handling

Diffstat:
M
src/backend/taler-merchant-httpd_private-get-orders-ID.c
 | 
1
+
M
src/backend/taler-merchant-httpd_private-post-orders.c
 | 
5
+++--

2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/backend/taler-merchant-httpd_private-get-orders-ID.c b/src/backend/taler-merchant-httpd_private-get-orders-ID.c
@@ -1009,6 +1009,7 @@ phase_unpaid_finish (struct GetOrderRequestContext *gorc)
                                                  gorc->contract_terms_json),
                  GNUNET_JSON_pack_string ("order_status",
                                           "claimed")));
+    GNUNET_free (order_status_url);
     return;
   }
   taler_pay_uri = TMH_make_taler_pay_uri (gorc->sc.con,
diff --git a/src/backend/taler-merchant-httpd_private-post-orders.c b/src/backend/taler-merchant-httpd_private-post-orders.c
@@ -184,7 +184,7 @@ struct OrderContext
     /**
      * Shared key to use with @e pos_algorithm.
      */
-    const char *pos_key;
+    char *pos_key;
 
     /**
      * Selected algorithm (by template) when we are to
@@ -846,6 +846,7 @@ clean_order (void *cls)
   GNUNET_array_grow (oc->parse_request.uuids,
                      oc->parse_request.uuids_length,
                      0);
+  GNUNET_free (oc->parse_request.pos_key);
   json_decref (oc->parse_request.order);
   json_decref (oc->serialize_order.contract);
   GNUNET_free (oc->parse_order.order_id);
@@ -3812,7 +3813,7 @@ parse_request (struct OrderContext *oc)
                         MHD_HTTP_NOT_FOUND,
                         TALER_EC_MERCHANT_GENERIC_OTP_DEVICE_UNKNOWN,
                         otp_id);
-      break;
+      return;
     case GNUNET_DB_STATUS_SUCCESS_ONE_RESULT:
       break;
     }