merchant

commit bd2e9f6088e949f695e44c38222be0a50c43b622
parent 715f38ee2fcfcafab081ce98fc698178edf3a5b1
Author: Christian Grothoff <christian@grothoff.org>
Date:   Wed, 10 Jan 2024 16:00:57 +0100

fix pg_insert_transfer_details.sql: narrow non-transferred deposits to relevant deposits

Diffstat:
M
src/backenddb/pg_insert_transfer_details.sql
 | 
8
++++----

1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/backenddb/pg_insert_transfer_details.sql b/src/backenddb/pg_insert_transfer_details.sql
@@ -194,7 +194,6 @@ LOOP
     FETCH NEXT FROM curs INTO my_affected_orders;
     EXIT WHEN NOT FOUND;
 
-    -- FIXME: statement below is messy, likely buggy (as we don't set WIRED to TRUE correctly...)
     RAISE NOTICE 'checking affected order for completion';
     UPDATE merchant_contract_terms
        SET wired=TRUE
@@ -205,13 +204,14 @@ LOOP
            order_serial=my_affected_orders.order_serial
            AND NOT EXISTS
            (SELECT 1
-              FROM merchant_deposits dep
+              FROM merchant_deposit_confirmations dcon
+              JOIN merchant_deposits dep
+                USING (deposit_confirmation_serial)
               JOIN merchant_deposit_to_transfer
                 USING (deposit_serial)
               JOIN merchant_transfers mtrans
                 USING (credit_serial)
-             WHERE
-               dep.deposit_confirmation_serial = dcon.deposit_confirmation_serial
+             WHERE dcon.order_serial=my_affected_orders.order_serial
                AND NOT mtrans.confirmed));
   END LOOP; -- END curs LOOP
   CLOSE curs;