commit 059a2cbcffec49396197c28aa472d10b9a4f6323
parent 8ac8e941587a029cab7a7fad7f94b3c79bd5755f
Author: Christian Grothoff <christian@grothoff.org>
Date: Sat, 29 Mar 2025 22:29:10 +0100
add missing assertions on rval
Diffstat:
1 file changed, 29 insertions(+), 18 deletions(-)
diff --git a/src/backenddb/test_merchantdb.c b/src/backenddb/test_merchantdb.c
@@ -720,6 +720,7 @@ make_product (const char *id,
product->product.description_i18n = json_array ();
GNUNET_assert (NULL != product->product.description_i18n);
product->product.unit = "boxes";
+ product->product.minimum_age = 0;
GNUNET_assert (GNUNET_OK ==
TALER_string_to_amount ("EUR:120.40",
&product->product.price));
@@ -1115,6 +1116,7 @@ pre_test_products (struct TestProducts_Closure *cls)
&cls->products[1]);
cls->products[1].product.description = "This is a another test product";
cls->products[1].product.unit = "cans";
+ cls->products[1].product.minimum_age = 0;
GNUNET_assert (GNUNET_OK ==
TALER_string_to_amount ("EUR:4.95",
&cls->products[1].product.price));
@@ -1438,18 +1440,25 @@ make_order (const char *order_id,
&order->claim_token,
sizeof (order->claim_token));
refund_deadline = GNUNET_TIME_relative_to_timestamp (GNUNET_TIME_UNIT_WEEKS);
- json_object_set_new (order->contract,
- "fulfillment_url",
- json_string ("a"));
- json_object_set_new (order->contract,
- "order_id",
- json_string (order_id));
- json_object_set_new (order->contract,
- "pay_deadline",
- GNUNET_JSON_from_timestamp (order->pay_deadline));
- json_object_set_new (order->contract,
- "refund_deadline",
- GNUNET_JSON_from_timestamp (refund_deadline));
+ GNUNET_assert (0 ==
+ json_object_set_new (order->contract,
+ "fulfillment_url",
+ json_string ("a")));
+ GNUNET_assert (0 ==
+ json_object_set_new (order->contract,
+ "order_id",
+ json_string (order_id)));
+ GNUNET_assert (0 ==
+ json_object_set_new (
+ order->contract,
+ "pay_deadline",
+ GNUNET_JSON_from_timestamp (order->pay_deadline))
+ );
+ GNUNET_assert (0 ==
+ json_object_set_new (order->contract,
+ "refund_deadline",
+ GNUNET_JSON_from_timestamp (
+ refund_deadline)));
}
@@ -2113,9 +2122,10 @@ pre_test_orders (struct TestOrders_Closure *cls)
make_order ("test_orders_od_2",
&cls->orders[2]);
- GNUNET_assert (0 == json_object_set_new (cls->orders[1].contract,
- "other_field",
- json_string ("Second contract")));
+ GNUNET_assert (0 ==
+ json_object_set_new (cls->orders[1].contract,
+ "other_field",
+ json_string ("Second contract")));
cls->orders[2].pay_deadline = GNUNET_TIME_UNIT_ZERO_TS;
GNUNET_assert (0 ==
@@ -2252,9 +2262,10 @@ run_test_orders (struct TestOrders_Closure *cls)
}
}
/* Test update contract terms */
- json_object_set_new (cls->orders[0].contract,
- "some_new_field",
- json_string ("another value"));
+ GNUNET_assert (0 ==
+ json_object_set_new (cls->orders[0].contract,
+ "some_new_field",
+ json_string ("another value")));
TEST_RET_ON_FAIL (test_update_contract_terms (&cls->instance,
&cls->orders[0],
GNUNET_DB_STATUS_SUCCESS_ONE_RESULT));