libeufin

commit b7207403cb0c66b4e2f635b2e06c7943d2e1478e
parent 6ec304b214ef21445175fac36f861237de4d0aaa
Author: Antoine A <>
Date:   Fri, 10 Nov 2023 15:10:25 +0000

Improve cashout API

Diffstat:
M
bank/src/main/kotlin/tech/libeufin/bank/CoreBankApi.kt
 | 
2
+-
M
bank/src/test/kotlin/CoreBankApiTest.kt
 | 
2
+-

2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/bank/src/main/kotlin/tech/libeufin/bank/CoreBankApi.kt b/bank/src/main/kotlin/tech/libeufin/bank/CoreBankApi.kt
@@ -580,7 +580,7 @@ private fun Routing.coreBankCashoutApi(db: Database, ctx: BankConfig) = conditio
                     "Cannot confirm an aborted cashout",
                     TalerErrorCode.BANK_CONFIRM_ABORT_CONFLICT
                 )
-                CashoutConfirmationResult.BAD_TAN_CODE -> throw forbidden(
+                CashoutConfirmationResult.BAD_TAN_CODE -> throw conflict(
                     "Incorrect TAN code",
                     TalerErrorCode.BANK_TAN_CHALLENGE_FAILED
                 )
diff --git a/bank/src/test/kotlin/CoreBankApiTest.kt b/bank/src/test/kotlin/CoreBankApiTest.kt
@@ -1234,7 +1234,7 @@ class CoreBankCashoutApiTest {
             client.post("/accounts/customer/cashouts/$id/confirm") {
                 basicAuth("customer", "customer-password")
                 jsonBody { "tan" to "nice-try" } 
-            }.assertForbidden(TalerErrorCode.BANK_TAN_CHALLENGE_FAILED)
+            }.assertConflict(TalerErrorCode.BANK_TAN_CHALLENGE_FAILED)
 
             val code = smsCode("+99")