libeufin

commit 69e82424445fb39133ca8e4f71be6823c51399f6
parent 6ec6d539216c2deb1afc0aec0b845c0267c1e23b
Author: Antoine A <>
Date:   Wed,  1 Nov 2023 11:34:45 +0000

Fix http status code

Diffstat:
M
bank/src/main/kotlin/tech/libeufin/bank/CoreBankApi.kt
 | 
4
++--
M
bank/src/test/kotlin/CoreBankApiTest.kt
 | 
4
++--

2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/bank/src/main/kotlin/tech/libeufin/bank/CoreBankApi.kt b/bank/src/main/kotlin/tech/libeufin/bank/CoreBankApi.kt
@@ -145,7 +145,7 @@ private fun Routing.coreBankAccountsMgmtApi(db: Database, ctx: BankConfig) {
             val req = call.receive<RegisterAccountRequest>()
             // Prohibit reserved usernames:
             if (reservedAccounts.contains(req.username))
-                throw forbidden(
+                throw conflict(
                     "Username '${req.username}' is reserved.",
                     TalerErrorCode.BANK_RESERVED_USERNAME_CONFLICT
                 )
@@ -194,7 +194,7 @@ private fun Routing.coreBankAccountsMgmtApi(db: Database, ctx: BankConfig) {
         delete("/accounts/{USERNAME}") {
             // Not deleting reserved names.
             if (reservedAccounts.contains(username))
-                throw forbidden(
+                throw conflict(
                     "Cannot delete reserved accounts",
                     TalerErrorCode.BANK_RESERVED_USERNAME_CONFLICT
                 )
diff --git a/bank/src/test/kotlin/CoreBankApiTest.kt b/bank/src/test/kotlin/CoreBankApiTest.kt
@@ -203,7 +203,7 @@ class CoreBankAccountsMgmtApiTest {
                     "password" to "password"
                     "name" to "John Smith"
                 })
-            }.assertForbidden().assertErr(TalerErrorCode.BANK_RESERVED_USERNAME_CONFLICT)
+            }.assertConflict().assertErr(TalerErrorCode.BANK_RESERVED_USERNAME_CONFLICT)
         }
 
         // Only admin can create exchange account
@@ -313,7 +313,7 @@ class CoreBankAccountsMgmtApiTest {
         reservedAccounts.forEach {
             client.delete("/accounts/$it") {
                 basicAuth("admin", "admin-password")
-            }.assertForbidden().assertErr(TalerErrorCode.BANK_RESERVED_USERNAME_CONFLICT)
+            }.assertConflict().assertErr(TalerErrorCode.BANK_RESERVED_USERNAME_CONFLICT)
         }
        
         // successful deletion