exchange

commit f2e2c5c9d81ede958bfdbddbab80d7a9a9ed4cb2
parent 937524940a9994340ccaf8c200bbac0b59da6cd0
Author: Christian Grothoff <christian@grothoff.org>
Date:   Tue,  7 Jun 2022 22:24:49 +0200

-fix refund check regression

Diffstat:
M
src/lib/exchange_api_refund.c
 | 
13
+++++--------

1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/src/lib/exchange_api_refund.c b/src/lib/exchange_api_refund.c
@@ -444,20 +444,14 @@ verify_conflict_history_ok (struct TALER_EXCHANGE_RefundHandle *rh,
   else
   {
     rtotal = rh->refund_amount;
+    have_refund = true;
   }
-  if ( (have_refund) && (! have_deposit) )
+  if (! have_deposit)
   {
     GNUNET_break (0);
     GNUNET_JSON_parse_free (spec);
     return GNUNET_SYSERR;
   }
-  if (! (have_refund && have_deposit))
-  {
-    /* need both for a refund-deposit conflict proof */
-    GNUNET_break (0);
-    GNUNET_JSON_parse_free (spec);
-    return GNUNET_SYSERR;
-  }
   if (-1 != TALER_amount_cmp (&dtotal,
                               &rtotal))
   {
@@ -649,6 +643,9 @@ handle_refund_finished (void *cls,
                                     j))
     {
       GNUNET_break (0);
+      json_dumpf (j,
+                  stderr,
+                  JSON_INDENT (2));
       hr.http_status = 0;
       hr.ec = TALER_EC_EXCHANGE_REFUND_INVALID_FAILURE_PROOF_BY_EXCHANGE;
       hr.hint = "conflict information provided by exchange is invalid";