exchange

commit e512e322a32c510e81c74ff4eec8de791753b496
parent 5bcfa61aee3e1d741407372f7f5141322f9cdd95
Author: Christian Grothoff <christian@grothoff.org>
Date:   Thu,  3 Jul 2025 17:13:53 +0200

move to modern offset/limit instead of deprecated start/delta in fakebank (#7949)

Diffstat:
M
src/bank-lib/fakebank_common_parser.c
 | 
36
++++++++++++++++++++++--------------

1 file changed, 22 insertions(+), 14 deletions(-)
diff --git a/src/bank-lib/fakebank_common_parser.c b/src/bank-lib/fakebank_common_parser.c
@@ -36,27 +36,35 @@ TALER_FAKEBANK_common_parse_history_args (
   struct MHD_Connection *connection,
   struct HistoryArgs *ha)
 {
-  const char *start;
-  const char *delta;
+  const char *offset;
+  const char *limit;
   const char *long_poll_ms;
   unsigned long long lp_timeout;
   unsigned long long sval;
   long long d;
   char dummy;
 
-  start = MHD_lookup_connection_value (connection,
+  offset = MHD_lookup_connection_value (connection,
+                                        MHD_GET_ARGUMENT_KIND,
+                                        "offset");
+  if (NULL == offset)
+    offset = MHD_lookup_connection_value (connection,
+                                          MHD_GET_ARGUMENT_KIND,
+                                          "start");
+  ha->have_start = (NULL != offset);
+  limit = MHD_lookup_connection_value (connection,
                                        MHD_GET_ARGUMENT_KIND,
-                                       "start");
-  ha->have_start = (NULL != start);
-  delta = MHD_lookup_connection_value (connection,
-                                       MHD_GET_ARGUMENT_KIND,
-                                       "delta");
+                                       "limit");
+  if (NULL == limit)
+    limit = MHD_lookup_connection_value (connection,
+                                         MHD_GET_ARGUMENT_KIND,
+                                         "limit");
   long_poll_ms = MHD_lookup_connection_value (connection,
                                               MHD_GET_ARGUMENT_KIND,
                                               "long_poll_ms");
   lp_timeout = 0;
-  if ( (NULL == delta) ||
-       (1 != sscanf (delta,
+  if ( (NULL == limit) ||
+       (1 != sscanf (limit,
                      "%lld%c",
                      &d,
                      &dummy)) )
@@ -93,8 +101,8 @@ TALER_FAKEBANK_common_parse_history_args (
            ? GNUNET_NO
            : GNUNET_SYSERR;
   }
-  if ( (NULL != start) &&
-       (1 != sscanf (start,
+  if ( (NULL != offset) &&
+       (1 != sscanf (offset,
                      "%llu%c",
                      &sval,
                      &dummy)) )
@@ -112,7 +120,7 @@ TALER_FAKEBANK_common_parse_history_args (
            ? GNUNET_NO
            : GNUNET_SYSERR;
   }
-  if (NULL == start)
+  if (NULL == offset)
     ha->start_idx = (d > 0) ? 0 : UINT64_MAX;
   else
     ha->start_idx = (uint64_t) sval;
@@ -124,7 +132,7 @@ TALER_FAKEBANK_common_parse_history_args (
             TALER_MHD_reply_with_error (connection,
                                         MHD_HTTP_BAD_REQUEST,
                                         TALER_EC_GENERIC_PARAMETER_MALFORMED,
-                                        "delta"))
+                                        "limit"))
            ? GNUNET_NO
            : GNUNET_SYSERR;
   }