exchange

commit e378b6121ee59c0fbddb9f769336a3bbcd1739cc
parent 7ecdd9aeb7452694067be580987603b0fff2726d
Author: Christian Grothoff <grothoff@gnunet.org>
Date:   Sat, 11 Jul 2026 20:31:15 +0200

fix leaks

Diffstat:
M
src/bank-lib/fakebank_bank.c
 | 
7
+++++++
M
src/bank-lib/fakebank_bank_post_withdrawals_id_op.c
 | 
1
+
M
src/bank-lib/fakebank_twg_get_transfers.c
 | 
3
++-
M
src/bank-lib/fakebank_twg_get_transfers_id.c
 | 
3
++-
M
src/bank-lib/fakebank_twg_history.c
 | 
3
++-
M
src/bank-lib/fakebank_twg_transfer.c
 | 
1
+

6 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/src/bank-lib/fakebank_bank.c b/src/bank-lib/fakebank_bank.c
@@ -454,6 +454,13 @@ TALER_FAKEBANK_bank_main_ (
             TALER_EC_GENERIC_CLIENT_INTERNAL_ERROR,
             url);
         }
+        GNUNET_break_op (0);
+        GNUNET_free (ci);
+        GNUNET_free (acc);
+        return TALER_MHD_reply_with_error (connection,
+                                           MHD_HTTP_NOT_FOUND,
+                                           TALER_EC_GENERIC_ENDPOINT_UNKNOWN,
+                                           url);
       }
 
       if (0 == strcmp (end_acc,
diff --git a/src/bank-lib/fakebank_bank_post_withdrawals_id_op.c b/src/bank-lib/fakebank_bank_post_withdrawals_id_op.c
@@ -278,6 +278,7 @@ TALER_FAKEBANK_bank_withdrawals_id_op_ (
     cc = GNUNET_new (struct ConnectionContext);
     cc->ctx_cleaner = &GNUNET_MHD_post_parser_cleanup;
     *con_cls = cc;
+    return MHD_YES;
   }
   if (0 != *upload_data_size)
   {
diff --git a/src/bank-lib/fakebank_twg_get_transfers.c b/src/bank-lib/fakebank_twg_get_transfers.c
@@ -179,7 +179,8 @@ TALER_FAKEBANK_twg_get_transfers_ (
       continue;
     }
     GNUNET_asprintf (&credit_payto,
-                     "payto://x-taler-bank/localhost/%s?receiver-name=%s",
+                     "payto://x-taler-bank/%s/%s?receiver-name=%s",
+                     h->hostname,
                      pos->credit_account->account_name,
                      pos->credit_account->receiver_name);
 
diff --git a/src/bank-lib/fakebank_twg_get_transfers_id.c b/src/bank-lib/fakebank_twg_get_transfers_id.c
@@ -94,7 +94,8 @@ TALER_FAKEBANK_twg_get_transfers_id_ (
       return MHD_NO;
     }
     GNUNET_asprintf (&credit_payto,
-                     "payto://x-taler-bank/localhost/%s?receiver-name=%s",
+                     "payto://x-taler-bank/%s/%s?receiver-name=%s",
+                     h->hostname,
                      t->credit_account->account_name,
                      t->credit_account->receiver_name);
     trans = GNUNET_JSON_PACK (
diff --git a/src/bank-lib/fakebank_twg_history.c b/src/bank-lib/fakebank_twg_history.c
@@ -226,7 +226,8 @@ TALER_FAKEBANK_twg_get_debit_history_ (
       continue;
     }
     GNUNET_asprintf (&credit_payto,
-                     "payto://x-taler-bank/localhost/%s?receiver-name=%s",
+                     "payto://x-taler-bank/%s/%s?receiver-name=%s",
+                     h->hostname,
                      pos->credit_account->account_name,
                      pos->credit_account->receiver_name);
 
diff --git a/src/bank-lib/fakebank_twg_transfer.c b/src/bank-lib/fakebank_twg_transfer.c
@@ -145,6 +145,7 @@ TALER_FAKEBANK_handle_transfer_ (
       uids = GNUNET_STRINGS_data_to_string_alloc (&uuid,
                                                   sizeof (uuid));
       json_decref (json);
+      GNUNET_free (credit);
       res = TALER_MHD_reply_with_error (connection,
                                         MHD_HTTP_CONFLICT,
                                         TALER_EC_BANK_TRANSFER_REQUEST_UID_REUSED,