exchange

commit dc9f41a7940a540df9d6f9a1d1b3a01c96176b11
parent e01bcbb2d4d7922829da20a75b4b18ffa8b1c374
Author: Christian Grothoff <christian@grothoff.org>
Date:   Tue, 23 Jun 2020 10:30:31 +0200

clarify with/without wire fee issue, sanity checks on currencies

Diffstat:
M
src/include/taler_exchange_service.h
 | 
2
+-
M
src/lib/exchange_api_transfers_get.c
 | 
6
++++++

2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/include/taler_exchange_service.h b/src/include/taler_exchange_service.h
@@ -1611,7 +1611,7 @@ struct TALER_EXCHANGE_TransferData
   struct GNUNET_TIME_Absolute execution_time;
 
   /**
-   * amount of the wire transfer; FIXME: total wired (without fee), or including @a wire_fee?
+   * Actual amount of the wire transfer, excluding the wire fee.
    */
   struct TALER_Amount total_amount;
 
diff --git a/src/lib/exchange_api_transfers_get.c b/src/lib/exchange_api_transfers_get.c
@@ -155,6 +155,12 @@ check_transfers_get_response_ok (
             GNUNET_JSON_parse (detail_j,
                                spec_detail,
                                NULL, NULL)) ||
+           (GNUNET_OK !=
+            TALER_amount_cmp_currency (&total_expected,
+                                       &detail->coin_value)) ||
+           (GNUNET_OK !=
+            TALER_amount_cmp_currency (&total_expected,
+                                       &detail->coin_fee)) ||
            (0 >
             TALER_amount_add (&total_expected,
                               &total_expected,