exchange

Base system with REST service to issue digital coins, run by the payment service provider
Log | Files | Refs | Submodules | README | LICENSE

commit da218509aa514bc961bbfdc2b8f64752d8885bc7
parent 2bf1a8f751ed91a31d9fc88d93cf558b1233a177
Author: Christian Grothoff <grothoff@gnunet.org>
Date:   Sat, 11 Jul 2026 18:40:10 +0200

-typos

Diffstat:
Msrc/auditor/taler-helper-auditor-aggregation.c | 6+++---
Msrc/exchange-tools/taler-auditor-offline.c | 25++++++++++++++-----------
Msrc/exchange-tools/taler-exchange-offline.c | 15+--------------
Msrc/exchange/taler-exchange-drain.c | 5++---
4 files changed, 20 insertions(+), 31 deletions(-)

diff --git a/src/auditor/taler-helper-auditor-aggregation.c b/src/auditor/taler-helper-auditor-aggregation.c @@ -993,9 +993,9 @@ wire_transfer_information_cb ( return; } } - if (0 != - TALER_amount_cmp (&total_deposit_without_refunds, - &coin_value_without_fee)) + else if (0 != + TALER_amount_cmp (&total_deposit_without_refunds, + &coin_value_without_fee)) { GNUNET_log (GNUNET_ERROR_TYPE_WARNING, "Expected coin contribution of %s to aggregate\n", diff --git a/src/exchange-tools/taler-auditor-offline.c b/src/exchange-tools/taler-auditor-offline.c @@ -51,7 +51,7 @@ struct DenominationAddRequest; #define OP_INPUT_KEYS "auditor-keys-0" /** - * Show the offline signing key. + * Setup the offline signing key. * The last component --by convention-- identifies the protocol version * and should be incremented whenever the JSON format of the 'argument' changes. */ @@ -138,7 +138,7 @@ struct SubCommand /** - * Data structure for wire add requests. + * Data structure for denomination add requests. */ struct DenominationAddRequest { @@ -222,7 +222,7 @@ do_shutdown (void *cls) if (NULL != in) { fprintf (stderr, - "Darning: input not consumed!\n"); + "Warning: input not consumed!\n"); json_decref (in); in = NULL; } @@ -431,7 +431,7 @@ denomination_add_cb ( * * @param exchange_url base URL of the exchange * @param idx index of the operation we are performing (for logging) - * @param value arguments for denomination revocation + * @param value arguments for adding denominations */ static void upload_denomination_add (const char *exchange_url, @@ -670,15 +670,17 @@ keys_cb ( case MHD_HTTP_OK: if (NULL == kr->hr.reply) { - GNUNET_break (0); + GNUNET_break_op (0); test_shutdown (); global_ret = EXIT_FAILURE; + if (NULL != keys) + TALER_EXCHANGE_keys_decref (keys); return; } break; default: fprintf (stderr, - "Failed to download keys: %s (HTTP status: %u/%u)\n", + "Failed to download keys: %s (HTTP status: %u/EC: %u)\n", kr->hr.hint, kr->hr.http_status, (unsigned int) kr->hr.ec); @@ -729,9 +731,10 @@ do_download (char *const *args) } exchange = TALER_EXCHANGE_get_keys_create (ctx, exchange_url); - TALER_EXCHANGE_get_keys_start (exchange, - &keys_cb, - args); + GNUNET_assert (TALER_EC_NONE == + TALER_EXCHANGE_get_keys_start (exchange, + &keys_cb, + args)); GNUNET_free (exchange_url); } @@ -1127,7 +1130,7 @@ sign_denomkeys (const json_t *denomkeys) &err_line)) { fprintf (stderr, - "Invalid input for denomination key to 'show': %s#%u at %u/%u (skipping)\n", + "Invalid input for denomination key to 'sign': %s#%u at %u/%u (skipping)\n", err_name, err_line, (unsigned int) group_idx, @@ -1338,7 +1341,7 @@ work (void *cls) { .name = "sign", .help = - "sing all denomination keys from the input", + "sign all denomination keys from the input", .cb = &do_sign }, { diff --git a/src/exchange-tools/taler-exchange-offline.c b/src/exchange-tools/taler-exchange-offline.c @@ -3579,19 +3579,6 @@ do_drain (char *const *args) } if ( (NULL == args[0]) || (NULL == args[1]) || - (NULL == args[2]) || - (GNUNET_OK != - TALER_string_to_amount (args[0], - &amount)) ) - { - GNUNET_log (GNUNET_ERROR_TYPE_ERROR, - "Drain requires an amount, section name and target payto://-URI as arguments\n"); - GNUNET_SCHEDULER_shutdown (); - global_ret = EXIT_INVALIDARGUMENT; - return; - } - if ( (NULL == args[0]) || - (NULL == args[1]) || (NULL == args[2]) ) { GNUNET_log (GNUNET_ERROR_TYPE_ERROR, @@ -3887,7 +3874,7 @@ do_set_aml_staff (bool is_active, * Disable AML staff. * * @param args the array of command-line arguments to process next; - * args[0] must be the AML staff's public key, args[1] the AML staff's legal name, args[2] rw (read write) or ro (read only) + * args[0] must be the AML staff's public key, args[1] the AML staff's legal name */ static void disable_aml_staff (char *const *args) diff --git a/src/exchange/taler-exchange-drain.c b/src/exchange/taler-exchange-drain.c @@ -289,6 +289,7 @@ run_drain (void *cls) "Exiting.\n"); TALER_EXCHANGEDB_rollback (pg); GNUNET_free (payto_uri.full_payto); + GNUNET_free (account_section); GNUNET_assert (NULL == task); GNUNET_SCHEDULER_shutdown (); global_ret = EXIT_FAILURE; @@ -298,9 +299,6 @@ run_drain (void *cls) break; } - /* Note: account_section ignored for now, we - might want to use it here in the future... */ - (void) account_section; { char *method; void *buf; @@ -322,6 +320,7 @@ run_drain (void *cls) GNUNET_free (buf); } GNUNET_free (payto_uri.full_payto); + GNUNET_free (account_section); switch (qs) { case GNUNET_DB_STATUS_HARD_ERROR: