exchange

commit d90b01a9f8eb0870ece10bbdb845ba34db334857
parent 41f2a7bfcb35cdf763b9af12dbb15d07733b6b33
Author: Christian Grothoff <christian@grothoff.org>
Date:   Mon,  2 Dec 2024 09:39:39 +0100

explain why fallbacks are not optional

Diffstat:
M
src/kyclogic/kyclogic_api.c
 | 
8
+++++++-

1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/src/kyclogic/kyclogic_api.c b/src/kyclogic/kyclogic_api.c
@@ -2037,7 +2037,13 @@ add_check (const struct GNUNET_CONFIGURATION_Handle *cfg,
                                              "FALLBACK",
                                              &fallback))
   {
-    /* FIXME: Allow NULL to fall back to default rules? */
+    /* We do *not* allow NULL to fall back to default rules because fallbacks
+       are used when there is actually a serious error and thus some action
+       (usually an investigation) is always in order, and that's basically
+       never the default. And as fallbacks should be rare, we really insist on
+       them at least being explicitly configured. Otherwise these errors may
+       go undetected simply because someone forgot to configure a fallback and
+       then nothing happens. */
     GNUNET_log_config_missing (GNUNET_ERROR_TYPE_ERROR,
                                section,
                                "FALLBACK");