exchange

commit c2549e8b1e43acc2c35b898062d5dcdb5e53ee6e
parent bc14c215b3a29da0d8fbb9c3f7b577a3155c2943
Author: Christian Grothoff <christian@grothoff.org>
Date:   Sat, 12 Feb 2022 11:24:32 +0100

-address FIXMEs

Diffstat:
M
src/exchange/taler-exchange-httpd_csr.c
 | 
3
+--
M
src/exchange/taler-exchange-httpd_refreshes_reveal.c
 | 
2
+-
M
src/exchangedb/plugin_exchangedb_postgres.c
 | 
3
---
M
src/exchangedb/test_exchangedb.c
 | 
1
-

4 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/src/exchange/taler-exchange-httpd_csr.c b/src/exchange/taler-exchange-httpd_csr.c
@@ -68,8 +68,7 @@ TEH_handler_csr (struct TEH_RequestContext *rc,
     return TALER_MHD_reply_with_error (
       rc->connection,
       MHD_HTTP_BAD_REQUEST,
-      // FIXME: generalize error message
-      TALER_EC_EXCHANGE_REFRESHES_REVEAL_NEW_DENOMS_ARRAY_SIZE_EXCESSIVE,
+      TALER_EC_EXCHANGE_GENERIC_NEW_DENOMS_ARRAY_SIZE_EXCESSIVE,
       NULL);
   }
   struct TALER_CsNonce nonces[GNUNET_NZL (csr_requests_num)];
diff --git a/src/exchange/taler-exchange-httpd_refreshes_reveal.c b/src/exchange/taler-exchange-httpd_refreshes_reveal.c
@@ -705,7 +705,7 @@ handle_refreshes_reveal_json (struct MHD_Connection *connection,
     GNUNET_break_op (0);
     return TALER_MHD_reply_with_error (connection,
                                        MHD_HTTP_BAD_REQUEST,
-                                       TALER_EC_EXCHANGE_REFRESHES_REVEAL_NEW_DENOMS_ARRAY_SIZE_EXCESSIVE,
+                                       TALER_EC_EXCHANGE_GENERIC_NEW_DENOMS_ARRAY_SIZE_EXCESSIVE,
                                        NULL);
 
   }
diff --git a/src/exchangedb/plugin_exchangedb_postgres.c b/src/exchangedb/plugin_exchangedb_postgres.c
@@ -6100,7 +6100,6 @@ postgres_insert_refresh_reveal (
       GNUNET_PQ_query_param_auto_from_type (&rrc->orig_coin_link_sig),
       GNUNET_PQ_query_param_auto_from_type (&rrc->h_denom_pub),
       TALER_PQ_query_param_blinded_planchet (&rrc->blinded_planchet),
-      // FIXME: needed? review link protocol!
       TALER_PQ_query_param_exchange_withdraw_values (&rrc->exchange_vals),
       GNUNET_PQ_query_param_auto_from_type (&rrc->coin_envelope_hash),
       TALER_PQ_query_param_blinded_denom_sig (&rrc->coin_sig),
@@ -6210,7 +6209,6 @@ add_revealed_coins (void *cls,
                                               &rrc->coin_envelope_hash),
         TALER_PQ_result_spec_blinded_planchet ("coin_ev",
                                                &rrc->blinded_planchet),
-        // FIXME: needed? review link protocol!
         TALER_PQ_result_spec_exchange_withdraw_values ("ewv",
                                                        &rrc->exchange_vals),
         TALER_PQ_result_spec_blinded_denom_sig ("ev_sig",
@@ -6396,7 +6394,6 @@ add_ldl (void *cls,
                                                 &pos->ev_sig),
         GNUNET_PQ_result_spec_uint32 ("freshcoin_index",
                                       &pos->coin_refresh_offset),
-        // FIXME: needed? review link protocol!
         TALER_PQ_result_spec_exchange_withdraw_values ("ewv",
                                                        &pos->alg_values),
         TALER_PQ_result_spec_denom_pub ("denom_pub",
diff --git a/src/exchangedb/test_exchangedb.c b/src/exchangedb/test_exchangedb.c
@@ -1480,7 +1480,6 @@ run (void *cls)
       &age_hash
     };
 
-    // FIXME:
     /* Call TALER_denom_blind()/TALER_denom_sign_blinded() twice, once without
      * age_hash, once with age_hash */
     RND_BLK (&age_hash);