commit b3aa1d2455f6abf518018a8bf0a810cb25997305
parent b8a241958d73e3f37b01905cc8985fd57384dcc2
Author: Christian Grothoff <christian@grothoff.org>
Date: Thu, 6 Aug 2026 22:55:35 +0200
dead (SQL) code elimination
Diffstat:
3 files changed, 3 insertions(+), 104 deletions(-)
diff --git a/src/exchangedb/sql-schema/exchange_do_select_justification_for_missing_wire.sql b/src/exchangedb/sql-schema/exchange_do_select_justification_for_missing_wire.sql
@@ -1,102 +0,0 @@
---
--- This file is part of TALER
--- Copyright (C) 2023 Taler Systems SA
---
--- TALER is free software; you can redistribute it and/or modify it under the
--- terms of the GNU General Public License as published by the Free Software
--- Foundation; either version 3, or (at your option) any later version.
---
--- TALER is distributed in the hope that it will be useful, but WITHOUT ANY
--- WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
--- A PARTICULAR PURPOSE. See the GNU General Public License for more details.
---
--- You should have received a copy of the GNU General Public License along with
--- TALER; see the file COPYING. If not, see <http://www.gnu.org/licenses/>
---
--- @author: Christian Grothoff
-
-CREATE OR REPLACE FUNCTION exchange_do_select_justification_missing_wire(
- IN in_wire_target_h_payto BYTEA,
- IN in_current_time INT8,
- OUT out_payto_uri TEXT, -- NULL allowed
- OUT out_kyc_pending TEXT, -- NULL allowed
- OUT out_aml_status INT4, -- NULL allowed
- OUT out_aml_limit taler_amount) -- NULL allowed!
-LANGUAGE plpgsql
-AS $$
-DECLARE
- my_required_checks TEXT[];
-DECLARE
- my_aml_data RECORD;
-DECLARE
- satisfied CURSOR FOR
- SELECT satisfied_checks
- FROM kyc_attributes
- WHERE h_payto=in_wire_target_h_payto
- AND expiration_time < in_current_time;
-DECLARE
- i RECORD;
-BEGIN
-
- -- Fetch payto URI
- out_payto_uri = NULL;
- SELECT payto_uri
- INTO out_payto_uri
- FROM wire_targets
- WHERE wire_target_h_payto=my_wire_target_h_payto;
-
- -- Check KYC status
- my_required_checks = NULL;
- SELECT string_to_array (required_checks, ' ')
- INTO my_required_checks
- FROM legitimization_requirements
- WHERE h_payto=my_wire_target_h_payto;
-
- -- Get last AML decision
- SELECT
- new_threshold
- ,kyc_requirements
- ,new_status
- INTO
- my_aml_data
- FROM aml_history
- WHERE h_payto=in_wire_target_h_payto
- ORDER BY aml_history_serial_id -- get last decision
- DESC LIMIT 1;
- IF FOUND
- THEN
- out_aml_limit=my_aml_data.new_threshold;
- out_aml_status=my_aml_data.kyc_status;
- -- Combine KYC requirements
- my_required_checks
- = array_cat (my_required_checks,
- my_aml_data.kyc_requirements);
- ELSE
- out_aml_limit=NULL;
- out_aml_status=0; -- or NULL? Style question!
- END IF;
-
- OPEN satisfied;
- LOOP
- FETCH NEXT FROM satisfied INTO i;
- EXIT WHEN NOT FOUND;
-
- -- remove all satisfied checks from the list
- FOR i in 1..array_length(i.satisfied_checks)
- LOOP
- my_required_checks
- = array_remove (my_required_checks,
- i.satisfied_checks[i]);
- END LOOP;
- END LOOP;
-
- -- Return remaining required checks as one string
- IF ( (my_required_checks IS NOT NULL) AND
- (0 < array_length(my_satisfied_checks)) )
- THEN
- out_kyc_pending
- = array_to_string (my_required_checks, ' ');
- END IF;
-
- RETURN;
-END $$;
diff --git a/src/exchangedb/sql-schema/meson.build b/src/exchangedb/sql-schema/meson.build
@@ -16,8 +16,6 @@ procedures_sql = [
# dead!?
'exchange_do_melt.sql',
'../iterate_batch_deposits_missing_wire.sql',
- # dead!?
- 'exchange_do_select_justification_for_missing_wire.sql',
'../do_refund.sql',
'../do_recoup.sql',
'../do_recoup_refresh.sql',
diff --git a/src/exchangedb/sql-schema/procedures-epilogue.sql b/src/exchangedb/sql-schema/procedures-epilogue.sql
@@ -30,4 +30,7 @@ END $$;
COMMENT ON PROCEDURE exchange_do_gc
IS 'calls all other garbage collection subroutines';
+-- exchange_do_select_justification_missing_wire() is dead code.
+DROP FUNCTION IF EXISTS exchange_do_select_justification_missing_wire;
+
COMMIT;
