exchange

commit a3dd7ad9994f16eb1938d2f9a1f68a99b25703cf
parent 77ebca5e9cee2c64a162be9a5e80abe0d3d49f2b
Author: Christian Grothoff <christian@grothoff.org>
Date:   Thu,  3 Nov 2022 22:19:41 +0100

-ref bug

Diffstat:
M
src/exchange/taler-exchange-httpd_purses_merge.c
 | 
2
+-
M
src/lib/exchange_api_reserves_open.c
 | 
2
+-
M
src/templating/templating_api.c
 | 
5
+----
M
src/util/exchange_signatures.c
 | 
3
+--

4 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/exchange/taler-exchange-httpd_purses_merge.c b/src/exchange/taler-exchange-httpd_purses_merge.c
@@ -169,7 +169,7 @@ reply_merge_success (struct MHD_Connection *connection,
   else
   {
 #if WAD_NOT_IMPLEMENTED
-    /* FIXME: figure out partner, lookup wad fee by partner! */
+    /* FIXME: figure out partner, lookup wad fee by partner! #7271 */
     if (0 >
         TALER_amount_subtract (&merge_amount,
                                &pcc->target_amount,
diff --git a/src/lib/exchange_api_reserves_open.c b/src/lib/exchange_api_reserves_open.c
@@ -282,7 +282,7 @@ handle_reserves_open_finished (void *cls,
     rs.hr.hint = TALER_JSON_get_error_hint (j);
     break;
   case MHD_HTTP_CONFLICT:
-    // FIXME: not yet specified, but needed in
+    // FIXME: not yet specified (#7428), but needed in
     // case of double-spending or insufficient
     // reserve balance!
     rs.hr.ec = TALER_JSON_get_error_code (j);
diff --git a/src/templating/templating_api.c b/src/templating/templating_api.c
@@ -191,13 +191,10 @@ TALER_TEMPLATING_build (struct MHD_Connection *connection,
                             template);
     if (NULL == tmpl)
     {
-      /* FIXME: should this not be an
-         internal failure? The language
-         mismatch is not critical here! */
       GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
                   "Failed to load template `%s'\n",
                   template);
-      *http_status = MHD_HTTP_NOT_ACCEPTABLE;
+      *http_status = MHD_HTTP_INTERNAL_SERVER_ERROR;
       *reply = TALER_MHD_make_error (TALER_EC_GENERIC_FAILED_TO_LOAD_TEMPLATE,
                                      template);
       return GNUNET_NO;
diff --git a/src/util/exchange_signatures.c b/src/util/exchange_signatures.c
@@ -454,8 +454,7 @@ struct TALER_ExchangeAccountSetupSuccessPS
    */
   struct TALER_PaytoHashP h_payto;
 
-  // FIXME: include details on *which* KYC process
-  // was satisfied! #7427
+  /* FIXME: include details on *which* KYC process was satisfied! #7427 */
 
   /**
    * When was the signature made.