exchange

commit 9c8bf277997257ff527bc10190aeb2d3fee94b23
parent b9762239f8b826de72c9718e0e9f09190591e265
Author: Christian Grothoff <christian@grothoff.org>
Date:   Sun,  8 Dec 2024 22:19:49 +0100

fix misc bugs

Diffstat:
M
src/auditor/taler-helper-auditor-aggregation.c
 | 
19
+++++++++++++------
M
src/bank-lib/fakebank_common_make_admin_transfer.c
 | 
1
+
M
src/exchange/taler-exchange-httpd_kyc-webhook.c
 | 
2
+-

3 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/src/auditor/taler-helper-auditor-aggregation.c b/src/auditor/taler-helper-auditor-aggregation.c
@@ -1101,9 +1101,10 @@ get_wire_fee (struct AggregationContext *ac,
           &TALER_ARL_master_pub,
           &master_sig))
     {
-      report_row_inconsistency ("wire-fee",
-                                timestamp.abs_time.abs_value_us,
-                                "wire fee signature invalid at given time");
+      ac->qs = report_row_inconsistency ("wire-fee",
+                                         timestamp.abs_time.abs_value_us,
+                                         "wire fee signature invalid at given time");
+      return NULL;
     }
   }
 
@@ -1263,9 +1264,15 @@ check_wire_out_cb (void *cls,
     }
     if (NULL == wire_fee)
     {
-      report_row_inconsistency ("wire-fee",
-                                date.abs_time.abs_value_us,
-                                "wire fee unavailable for given time");
+      qs = report_row_inconsistency ("wire-fee",
+                                     date.abs_time.abs_value_us,
+                                     "wire fee unavailable for given time");
+      if (qs < 0)
+      {
+        ac->qs = qs;
+        GNUNET_free (method);
+        return GNUNET_SYSERR;
+      }
       /* If fee is unknown, we just assume the fee is zero */
       final_amount = wcc.total_deposits;
     }
diff --git a/src/bank-lib/fakebank_common_make_admin_transfer.c b/src/bank-lib/fakebank_common_make_admin_transfer.c
@@ -105,6 +105,7 @@ TALER_FAKEBANK_make_admin_transfer_ (
     GNUNET_free (t);
     GNUNET_assert (0 ==
                    pthread_mutex_unlock (&h->rpubs_lock));
+    return GNUNET_NO;
   }
   GNUNET_assert (0 ==
                  pthread_mutex_unlock (&h->rpubs_lock));
diff --git a/src/exchange/taler-exchange-httpd_kyc-webhook.c b/src/exchange/taler-exchange-httpd_kyc-webhook.c
@@ -335,7 +335,7 @@ clean_kwh (struct TEH_RequestContext *rc)
   }
   if (NULL != kwh->webhook_response)
   {
-    MHD_destroy_response (kwh->response);
+    MHD_destroy_response (kwh->webhook_response);
     kwh->webhook_response = NULL;
   }
   GNUNET_free (kwh);