exchange

commit 6c5155ca74287add72e7a9a79bf274f2adc4fb3a
parent 376277f7e89ae9d994c2633ab1bf920851508a16
Author: Christian Grothoff <christian@grothoff.org>
Date:   Fri, 17 Jan 2020 20:11:43 +0100

Florian says libeufin will reject reserve pubs from alternating bank accounts

Diffstat:
M
src/exchangedb/plugin_exchangedb_postgres.c
 | 
17
-----------------

1 file changed, 0 insertions(+), 17 deletions(-)
diff --git a/src/exchangedb/plugin_exchangedb_postgres.c b/src/exchangedb/plugin_exchangedb_postgres.c
@@ -1885,23 +1885,6 @@ postgres_reserves_in_insert (void *cls,
     GNUNET_break (GNUNET_DB_STATUS_SOFT_ERROR == reserve_exists);
     return reserve_exists;
   }
-  if ( (0 == reserve.balance.value) &&
-       (0 == reserve.balance.fraction) )
-  {
-    /* TODO: reserve balance is empty, we might want to update
-       sender_account_details here.  (So that IF a customer uses the
-       same reserve public key from a different account, we USUALLY
-       switch to the new account (but only if the old reserve was
-       drained).)  This helps make sure that on reserve expiration the
-       funds go back to a valid account in cases where the customer
-       has closed the old bank account and some (buggy?) wallet keeps
-       using the same reserve key with the customer's new account.
-
-       Note that for a non-drained reserve we should not switch,
-       as that opens an attack vector for an adversary who can see
-       the wire transfer subjects (i.e. when using Bitcoin).
-    */}
-
   GNUNET_log (GNUNET_ERROR_TYPE_INFO,
               "Creating reserve %s with expiration in %s\n",
               TALER_B2S (reserve_pub),