exchange

commit 600dbaf594320bc8c83cec26ee6bdf9b5f48222d
parent da44aa567988e7c69eae85f6e542a95422ad5833
Author: Christian Grothoff <christian@grothoff.org>
Date:   Wed,  3 Jun 2015 11:43:57 +0200

remarks on #3808

Diffstat:
M
src/include/taler_mintdb_plugin.h
 | 
12
+++++++++++-
M
src/mintdb/plugin_mintdb_postgres.c
 | 
4
+++-

2 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/src/include/taler_mintdb_plugin.h b/src/include/taler_mintdb_plugin.h
@@ -651,8 +651,16 @@ struct TALER_MINTDB_Plugin
   (*rollback) (void *cls,
                struct TALER_MINTDB_Session *sesssion);
 
+
   /**
-   * Insert a denomination key
+   * Insert a denomination key.
+   *
+   * FIXME: Note that the main mint currently does NOT use this API at
+   * all.  Furthermore, the function to retrieve denomination keys
+   * from the DB is still missing.  The main mint should check if its
+   * denomination keys are in the DB, and if not, insert them (when it
+   * loads them).  The auditor will (presumably) need the denomination
+   * key information to audit the DB. (#3808).
    *
    * @param cls the @e cls of this struct with the plugin-specific state
    * @param sesssion connection to use
@@ -665,6 +673,8 @@ struct TALER_MINTDB_Plugin
                           const struct TALER_MINTDB_DenominationKeyIssueInformation *dki);
 
 
+
+
   /**
    * Get the summary of a reserve.
    *
diff --git a/src/mintdb/plugin_mintdb_postgres.c b/src/mintdb/plugin_mintdb_postgres.c
@@ -89,6 +89,7 @@
     PQclear (result);                                                   \
   } while (0)
 
+
 /**
  * Run an SQL statement, ignoring errors and clearing the result.
  *
@@ -123,7 +124,7 @@ struct PostgresClosure
 
   /**
    * Thread-local database connection.
-   * Contains a pointer to PGconn or NULL.
+   * Contains a pointer to `PGconn` or NULL.
    */
   pthread_key_t db_conn_threadlocal;
 
@@ -374,6 +375,7 @@ postgres_create_tables (void *cls,
           ",wire TEXT NOT NULL"
           ")");
 #undef SQLEXEC
+#undef SQLEXEC_INDEX
 
   PQfinish (conn);
   return GNUNET_OK;