exchange

commit 4e380d4937da4d51809d57eb60d4b6f0650483a9
parent a4af8963703abb882b08e75f20ef3e525447551e
Author: Christian Grothoff <grothoff@gnunet.org>
Date:   Tue, 17 Oct 2023 10:24:18 +0200

remove select-* logics'

Diffstat:
M
src/exchangedb/exchange_do_age_withdraw.sql
 | 
5
+++--
M
src/exchangedb/exchange_do_batch_withdraw.sql
 | 
6
++++--
M
src/exchangedb/exchange_do_recoup_by_reserve.sql
 | 
9
+++++++--
M
src/exchangedb/exchange_do_reserve_open.sql
 | 
6
+++---

4 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/src/exchangedb/exchange_do_age_withdraw.sql b/src/exchangedb/exchange_do_age_withdraw.sql
@@ -49,8 +49,9 @@ BEGIN
 --         reserves_in by reserve_pub (SELECT)
 --         wire_targets by wire_target_h_payto
 
--- FIXME-Oec: never select-*!
-SELECT *
+SELECT current_balance
+      ,birthday
+      ,gc_date
   INTO reserve
   FROM exchange.reserves
  WHERE reserves.reserve_pub=rpub;
diff --git a/src/exchangedb/exchange_do_batch_withdraw.sql b/src/exchangedb/exchange_do_batch_withdraw.sql
@@ -41,8 +41,10 @@ BEGIN
 --         reserves_in by reserve_pub (SELECT)
 --         wire_targets by wire_target_h_payto
 
--- FIXME-Oec: do not use select-*!
-SELECT *
+SELECT current_balance
+      ,reserve_uuid
+      ,birthday
+      ,gc_date
   INTO reserve
   FROM exchange.reserves
  WHERE reserves.reserve_pub=rpub;
diff --git a/src/exchangedb/exchange_do_recoup_by_reserve.sql b/src/exchangedb/exchange_do_recoup_by_reserve.sql
@@ -62,12 +62,17 @@ BEGIN
              rc.amount,
              rc.recoup_timestamp
       FROM (
-        SELECT * --FIXME: bad code, we never use '*'!
+        SELECT denom_sig
+              ,denominations_serial
         FROM exchange.known_coins
         WHERE known_coins.coin_pub = c_pub
       ) kc
       JOIN (
-        SELECT *  --FIXME: bad code, we never use '*'!
+        SELECT coin_pub
+              ,coin_sig
+              ,coin_blind
+              ,amount
+              ,recoup_timestamp
         FROM exchange.recoup
         WHERE recoup.coin_pub = c_pub
       ) rc USING (coin_pub);
diff --git a/src/exchangedb/exchange_do_reserve_open.sql b/src/exchangedb/exchange_do_reserve_open.sql
@@ -43,9 +43,9 @@ DECLARE
   reserve RECORD;
 BEGIN
 
--- FIXME: do not use SELECT-*
--- FIXME: use SELECT FOR UPDATE?
-SELECT *
+SELECT current_balance
+      ,expiration_time
+      ,purses_allowed
   INTO reserve
   FROM reserves
  WHERE reserve_pub=in_reserve_pub;