exchange

commit 36ccd301bbdf96fd9772c8bda1cc42bbf4ffacef
parent e1fe4a90bba5d8827f51b8d9f5f7ddaf57f46fed
Author: Christian Grothoff <grothoff@gnunet.org>
Date:   Thu,  1 May 2025 15:21:15 +0200

clarify comments on find_denomination()

Diffstat:
M
src/exchange/taler-exchange-httpd_melt_v27.c
 | 
13
+++++++------

1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/exchange/taler-exchange-httpd_melt_v27.c b/src/exchange/taler-exchange-httpd_melt_v27.c
@@ -607,9 +607,9 @@ phase_parse_request (
  * @param[in,out] mc context for the melt operation
  * @param denom_h Hash of the denomination key to check
  * @param[out] pdk denomination key found, might be NULL
- * @return GNUNET_OK when denomation was found and valid,
- *              GNUNET_NO when denomination was not valid but request was idempotent,
- *              GNUNET_SYSERR otherwise (denomination invalid), with finish_loop called.
+ * @return #GNUNET_OK when denomation was found and valid,
+ *         #GNUNET_NO when denomination is not valid at this time
+ *         #GNUNET_SYSERR otherwise (denomination invalid), with finish_loop called.
  */
 static enum GNUNET_GenericReturnValue
 find_denomination (
@@ -618,10 +618,9 @@ find_denomination (
   struct TEH_DenominationKey **pdk)
 {
   struct TEH_DenominationKey *dk;
-  *pdk = NULL;
 
+  *pdk = NULL;
   GNUNET_assert (NULL != mc->ksh);
-
   dk = TEH_keys_denomination_by_hash_from_state (
     mc->ksh,
     denom_h,
@@ -724,7 +723,8 @@ phase_check_keys (
   {
     struct TEH_DenominationKey *dk;
 
-    if (GNUNET_OK != find_denomination (
+    if (GNUNET_OK !=
+        find_denomination (
           mc,
           &mc->request.denoms_h[i],
           &dk))
@@ -935,6 +935,7 @@ phase_check_melt_valid (struct MeltContext *mc)
    * We reset the phase.
    */
   mc->phase = current_phase;
+  mc->error.code = MELT_ERROR_NONE;
 
   if (GNUNET_TIME_absolute_is_past (
         mc->melted_coin_denom->meta.expire_deposit.abs_time))