commit 347d6212dc6fc6cc0cc099b5206df9598148b869
parent 992aa883075503fb4af472f0fdb197cebf67641c
Author: Christian Grothoff <christian@grothoff.org>
Date: Sun, 8 Nov 2026 22:49:27 +0100
stop further processing after we hit failure
Diffstat:
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/auditor/taler-helper-auditor-coins.c b/src/auditor/taler-helper-auditor-coins.c
@@ -2844,7 +2844,9 @@ recoup_refresh_cb (struct CoinContext *cc,
* denomination and to warn if there are denominations not approved
* by this auditor.
*
- * @param iqs closure, pointer to `enum GNUNET_DB_QueryStatus`
+ * @param[in,out] iqs closure, pointer to `enum GNUNET_DB_QueryStatus`;
+ * a failure is latched here, we never overwrite a failure
+ * of a previous invocation with a success of this one
* @param denom_serial row ID of the denominations table of the exchange DB
* @param denom_pub public key, sometimes NULL (!)
* @param issue issuing information with value, fees and other info about the denomination.
@@ -2860,6 +2862,8 @@ check_denomination (
struct TALER_AuditorSignatureP auditor_sig;
(void) denom_pub;
+ if (0 > *iqs)
+ return; /* already failed, do not do more work */
qs = TALER_EXCHANGEDB_get_auditor_denom_sig (TALER_ARL_edb,
&issue->denom_hash,
&TALER_ARL_auditor_pub,
@@ -2928,7 +2932,6 @@ check_denomination (
return;
}
}
- *iqs = qs;
}