exchange

commit 2d8ee57a1db2aec4b429f415efb7c68509702abf
parent 6af7b5f0002277ef06a6de2b98bff01dda5094d1
Author: Christian Grothoff <christian@grothoff.org>
Date:   Sat, 22 Feb 2025 22:29:35 +0100

-explain more

Diffstat:
M
src/exchange/taler-exchange-httpd_kyc-upload.c
 | 
7
+++----
M
src/exchangedb/exchange_do_create_tables.sql
 | 
9
+++++----
M
src/kyclogic/taler-exchange-helper-measure-enable-deposits
 | 
2
+-

3 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/src/exchange/taler-exchange-httpd_kyc-upload.c b/src/exchange/taler-exchange-httpd_kyc-upload.c
@@ -258,10 +258,9 @@ upload_cleaner (struct TEH_RequestContext *rc)
 
 
 /**
- * Iterator over key-value pairs where the value
- * may be made available in increments and/or may
- * not be zero-terminated.  Used for processing
- * POST data.
+ * Iterator over key-value pairs where the value may be made available in
+ * increments and/or may not be zero-terminated.  Used for processing POST
+ * data.
  *
  * @param cls user-specified closure
  * @param kind type of the value, always #MHD_POSTDATA_KIND when called from MHD
diff --git a/src/exchangedb/exchange_do_create_tables.sql b/src/exchangedb/exchange_do_create_tables.sql
@@ -43,7 +43,7 @@ BEGIN
   FOR rec IN tc
   LOOP
     CASE rec.action
-    -- "create" actions apply to master and partitions
+    -- "create" actions apply to master and partitions, providing the partition ID to the creation function (if any)
     WHEN 'create'
     THEN
       IF (rec.partitioned AND
@@ -104,7 +104,7 @@ BEGIN
         'DROP FUNCTION exchange.create_table_%s'::text
           ,rec.name
         );
-    -- "alter" actions apply to master and partitions
+    -- "alter" actions apply to master and partitions (but are called without partition ID, as altering master applies to partitions for these); use when changing table layouts (adding or removing columns).
     WHEN 'alter'
     THEN
       -- Alter master table.
@@ -116,7 +116,7 @@ BEGIN
         'DROP FUNCTION exchange.alter_table_%s'::text
           ,rec.name
         );
-    -- Constrain action apply to master OR each partition
+    -- Constrain action apply to master OR each partition (but not on master if we have partitions); use to create (or remove) indices or constraints that apply to a partition and may not be aligned with the partition key
     WHEN 'constrain'
     THEN
       ASSERT rec.partitioned, 'constrain action only applies to partitioned tables';
@@ -152,7 +152,7 @@ BEGIN
         'DROP FUNCTION exchange.constrain_table_%s'::text
           ,rec.name
         );
-    -- Foreign actions only apply if partitioning is off
+    -- Foreign actions only apply if partitioning is off; use for foreign-key constraints that may span partitions
     WHEN 'foreign'
     THEN
       IF (num_partitions IS NULL)
@@ -168,6 +168,7 @@ BEGIN
         'DROP FUNCTION exchange.foreign_table_%s'::text
           ,rec.name
         );
+    -- "master" actions only apply to the master table
     WHEN 'master'
     THEN
       EXECUTE FORMAT(
diff --git a/src/kyclogic/taler-exchange-helper-measure-enable-deposits b/src/kyclogic/taler-exchange-helper-measure-enable-deposits
@@ -100,7 +100,7 @@ EXPIRATION_TIME=$(echo "$INPUTS" | jq '.context.expiration_time // .current_rule
 SUCCESSOR_MEASURE=$(echo "$INPUTS" | jq '.context.successor_measure // .current_rules.successor_measure // null')
 
 # Validate accepted ToS version
-if $(echo "$TOS_ACCEPTED" | grep "${EXCHANGE_TERMS_ETAG}" > /dev/null)
+if $(echo "$TOS_ACCEPTED" | grep "${EXCHANGE_AML_PROGRAM_TOPS_ENABLE_DEPOSITS_TOS_NAME}" > /dev/null)
 then
     # Valid ToS acceptance
     # Remove limitation from current rules.