exchange

commit 2c8afda8b3ead9f63cd004b47365fc831428cf21
parent 15ed6ffb07e2c1b87f08a1b168e76c743a2ae944
Author: Christian Grothoff <christian@grothoff.org>
Date:   Mon,  1 Mar 2021 14:08:15 +0100

remove deadlocking log statements

Diffstat:
M
src/util/taler-exchange-secmod-eddsa.c
 | 
12
------------
M
src/util/taler-exchange-secmod-rsa.c
 | 
9
---------
M
src/util/url.c
 | 
5
+++--

3 files changed, 3 insertions(+), 23 deletions(-)
diff --git a/src/util/taler-exchange-secmod-eddsa.c b/src/util/taler-exchange-secmod-eddsa.c
@@ -342,8 +342,6 @@ static void *
 sign_worker (void *cls)
 {
   (void) cls;
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Crypto worker launching\n");
   GNUNET_assert (0 == pthread_mutex_lock (&work_lock));
   while (! in_shutdown)
   {
@@ -357,9 +355,6 @@ sign_worker (void *cls)
                                    wi);
       work_counter--;
       GNUNET_assert (0 == pthread_mutex_unlock (&work_lock));
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                  "Processing sign request %p\n",
-                  wi);
       {
         if (GNUNET_OK !=
             GNUNET_CRYPTO_eddsa_sign_ (&wi->key->exchange_priv.eddsa_priv,
@@ -391,16 +386,12 @@ sign_worker (void *cls)
     if (in_shutdown)
       break;
     /* queue is empty, wait for work */
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Crypto worker waiting for work...\n");
     GNUNET_assert (0 ==
                    pthread_cond_wait (&work_cond,
                                       &work_lock));
   }
   GNUNET_assert (0 ==
                  pthread_mutex_unlock (&work_lock));
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Crypto worker exiting\n");
   return NULL;
 }
 
@@ -549,9 +540,6 @@ handle_done (void *cls)
         .exchange_sig = wi->signature
       };
 
-      GNUNET_log (GNUNET_ERROR_TYPE_INFO,
-                  "Transmitting signature for request %p\n",
-                  wi);
       (void) transmit (&wi->addr,
                        wi->addr_size,
                        &sr.header);
diff --git a/src/util/taler-exchange-secmod-rsa.c b/src/util/taler-exchange-secmod-rsa.c
@@ -410,8 +410,6 @@ static void *
 sign_worker (void *cls)
 {
   (void) cls;
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Crypto worker launching\n");
   GNUNET_assert (0 == pthread_mutex_lock (&work_lock));
   while (! in_shutdown)
   {
@@ -425,9 +423,6 @@ sign_worker (void *cls)
                                    wi);
       work_counter--;
       GNUNET_assert (0 == pthread_mutex_unlock (&work_lock));
-      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                  "Processing sign request %p\n",
-                  wi);
       wi->rsa_signature
         = GNUNET_CRYPTO_rsa_sign_blinded (wi->dk->denom_priv.rsa_private_key,
                                           wi->blinded_msg,
@@ -454,16 +449,12 @@ sign_worker (void *cls)
     if (in_shutdown)
       break;
     /* queue is empty, wait for work */
-    GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                "Crypto worker waiting for work...\n");
     GNUNET_assert (0 ==
                    pthread_cond_wait (&work_cond,
                                       &work_lock));
   }
   GNUNET_assert (0 ==
                  pthread_mutex_unlock (&work_lock));
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-              "Crypto worker exiting\n");
   return NULL;
 }
 
diff --git a/src/util/url.c b/src/util/url.c
@@ -247,8 +247,9 @@ TALER_url_join (const char *base_url,
   {
     /* Must be an actual base URL! */
     GNUNET_log (GNUNET_ERROR_TYPE_ERROR,
-                "Base URL `%s' does not end with '/'\n",
-                base_url);
+                "Base URL `%s' does not end with '/', cannot join with `%s'\n",
+                base_url,
+                path);
     return NULL;
   }
   if ('/' == path[0])